Code Monkey home page Code Monkey logo

Comments (4)

raamcosta avatar raamcosta commented on May 27, 2024 1

Im saying those are two different kinds of bottom sheets. You can use both material and navigation bottom sheets in the same app.
Material ones cannot be destinations, they’re something you show or hide as part of another screen.
Navigation ones are something else, they’re not material 2 or 3, they are their own thing.

from compose-destinations.

cj1098 avatar cj1098 commented on May 27, 2024 1

Gotcha. Thanks for the clarification!

from compose-destinations.

raamcosta avatar raamcosta commented on May 27, 2024

Hi @cj1098

The bottom sheets used on navigation is the same that official libraries provide (not just accompanist - it was imported to official library too).
Material bottom sheets can still be used, just not as a navigation destination.

There is no work to be done here 🙂

from compose-destinations.

cj1098 avatar cj1098 commented on May 27, 2024

@raamcosta Thanks for replying!
So you're saying if we move to material3's bottom sheets it's not possible to have them be destinations?
Previously when we declared our BottomSheetLayout we would say something like:
ModalBottomSheetLayout( bottomSheetNavigator = bottomSheetNavigator, )
Where we could pass in a bottomSheetNavigator that was provided via accompanist. In the m3 version it doesn't support a bottomSheetNavigator.
I do see that official libraries from androidx do support bottom sheets as navigation. So if we wanted to use m3 and still be able to navigate to bottom sheets we'd need to look to use one of those libraries?

from compose-destinations.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.