Comments (4)
Im saying those are two different kinds of bottom sheets. You can use both material and navigation bottom sheets in the same app.
Material ones cannot be destinations, they’re something you show or hide as part of another screen.
Navigation ones are something else, they’re not material 2 or 3, they are their own thing.
from compose-destinations.
Gotcha. Thanks for the clarification!
from compose-destinations.
Hi @cj1098
The bottom sheets used on navigation is the same that official libraries provide (not just accompanist - it was imported to official library too).
Material bottom sheets can still be used, just not as a navigation destination.
There is no work to be done here 🙂
from compose-destinations.
@raamcosta Thanks for replying!
So you're saying if we move to material3's bottom sheets it's not possible to have them be destinations?
Previously when we declared our BottomSheetLayout we would say something like:
ModalBottomSheetLayout( bottomSheetNavigator = bottomSheetNavigator, )
Where we could pass in a bottomSheetNavigator that was provided via accompanist. In the m3 version it doesn't support a bottomSheetNavigator.
I do see that official libraries from androidx do support bottom sheets as navigation. So if we wanted to use m3 and still be able to navigate to bottom sheets we'd need to look to use one of those libraries?
from compose-destinations.
Related Issues (20)
- ModuleDestinations$Includes is defined multiple times in Multi-Module project HOT 4
- [ksp] java.lang.NullPointerException when using custom NavArgument type HOT 13
- No NavGraphs in V2 HOT 14
- Support for Shared Element Transition. HOT 2
- Tab navigation support. HOT 1
- Can not make dependenciesContainerBuilder example work HOT 2
- Serializer for class 'DirectionImpl' is not found in v2 HOT 10
- [2.1.0-beta03] Navgraphs.* cannot be imported in the generated NavGraphs HOT 3
- navargs.* cannot be imported in ArgsToSavedStateHandle.kt HOT 2
- HorizontalPager pageContent can't save state HOT 2
- NavGraphArhs are visible only in "start" destination HOT 6
- Removing from composition and re-adding when navigating HOT 3
- java.lang.IllegalStateException: Duplicate route found X_destination'. Routes must be unique!. In Muli-module project. HOT 2
- Missing classes detected while running R8 on AGP 8.4.0 HOT 2
- Video tutorials for using the library. HOT 1
- [KSP][2.1.0] _ModuleRegistry missing visibility modifiers HOT 4
- [DEEPLINK][2.1.0] Request to bring back withDeepLink() HOT 9
- Can compose-destinations used in compose for desktop project ? HOT 1
- Accompanist Navigation Material functionality now available in androidx.compose.material.navigation.*
- "Reproducible build" possible with Compose Destinations? HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from compose-destinations.