Code Monkey home page Code Monkey logo

Comments (7)

FooIbar avatar FooIbar commented on September 22, 2024 1

You scared me for a moment.. I thought for a moment that they would be dropping that completely 😅 made no sense but we never know..

I should have made it clearer. That is only for testing KSP2 compatibility with 1.0.20 FooIbar@d7e79dd.

Update: Tested with 1.0.21, it's only partially fixed. Filed a bug on KSP google/ksp#1910.

from compose-destinations.

Nek-12 avatar Nek-12 commented on September 22, 2024

Looks like K2 is enabled by default in Kotlin 2.0. Did anyone get the library working with k2 enabled?

from compose-destinations.

FooIbar avatar FooIbar commented on September 22, 2024

You can use it with K2, we've been doing that for a while, just don't use KSP2.

from compose-destinations.

FooIbar avatar FooIbar commented on September 22, 2024

Looks like FooIbar@7875839 is the only change needed to support KSP2.
Note KSP 1.0.20 does not have google/ksp#1871, so those arguments that have class literals as default values need to be explicitly specified, e.g.

@Destination<RootGraph>(navArgs = Nothing::class, style = DestinationStyle.Default::class)

from compose-destinations.

raamcosta avatar raamcosta commented on September 22, 2024

Ok thank you @FooIbar

But just so we're clear. Using 1.0.20 KSP means we'd have to specify all field defaults for annotations that have class types, but only if using K2 as well, right?

from compose-destinations.

FooIbar avatar FooIbar commented on September 22, 2024

Ok thank you @FooIbar

But just so we're clear. Using 1.0.20 KSP means we'd have to specify all field defaults for annotations that have class types, but only if using K2 as well, right?

Yes, only if using KSP2.
That fix has been cherry-picked to the 1.0.21 branch google/ksp@fc0cdbf, which should be released soon?

from compose-destinations.

raamcosta avatar raamcosta commented on September 22, 2024

You scared me for a moment.. I thought for a moment that they would be dropping that completely 😅 made no sense but we never know..

from compose-destinations.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.