Comments (3)
Hi,
I believe all the pointers were already removed altogether in 6bf1ed0. If it's at all possible I would recommend merging with that commit. It removes a LOT of my convoluted code and other messy stuff, + better explanation comments. (or even later 323b441)
Otherwise let me know if you need any help even with the older commits. I might have to go through them a bit though.
from imstudio.
I think I found the issue.
if (!current_child)
{
Object widget(idvar, type_);
objects.push_back(widget);
}
Here in ims_buffer.cpp
you construct a stack allocated Object
, and then copy it into a std::vector
. This basically invalidates the Object* parent
pointer, because it's pointing to the stack allocated object that will soon be destroyed.
Now, I actually thought you could do something like this instead:
if (!current_child)
{
objects.emplace_back(std::move(Object(idvar, type_)));
}
But it turns out that this doesn't fix the problem. Unless you happen to have a solution in mind, the only other way I know of to fix this is to turn std::vector<Object> objects
into this instead: std::vector<Object*> objects
and just deal with the manual memory management.
Edit: Someone brought to my attention that std::unique_ptr
could also be used to alleviate the need to manage memory by hand. Like so:
std::vector<std::unique_ptr<Object>> objects;
auto widget = std::make_unique<Object>(idvar, type_);
objects.push_back(std::move(widget));
from imstudio.
See ac16cd8 for the solution I went with.
from imstudio.
Related Issues (8)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from imstudio.