Comments (1)
Absolutely! Would love to get some more API endpoints wrapped with R code.
My thoughts to your bullets:
Should there be separate user-level functions for add, update and removing shared links, or attempt to consolidate?
I think there are probably at least 7 functions.
3 internal: GET _shared_link, GET _shared_link/file_id, PUT _shared_link/file_id
4 external: find_folder, get_link, add_link, delete_link
Whether to ignore bad param combinations as i currently do or throw errors
I think boxr
should faithfully return the APIs response here. If there is an error throw it, if not carry on.
Including the unshared at and vanity name request options
We should be exposing as much of the API as possible for users to manipulate. I think these should be included
What should be an internal vs external function in boxr
Externals are nice human readables that collect arguments for the Internals, like get tokens and paths, maybe decorate with classes.
Internals are the cURL commands, doing the RETRY logic, the GET / PUT path the API wants.
I haven't done anything to wrap the httr result into a boxr object, so need to figure out which ones are available/whether we need a new one
Lets save this for last
Is there anything more opinionated that we could do? Some vague ideas include combining the file and folder endpoints, or adding auto share to some of the upload functions.
Combining endpoints might be less verbose if the two APIs are identical. But the API separated for them for a reason, keeping them separated for our wrappers is safer in case things change in the future.
Naming, as always!
Save this for last, last!
Does any of that not make sense?
I think starting with the code you have and adding some unit test cases for this would be the best place to start a PR.
from boxr.
Related Issues (20)
- shinyapps.io HOT 5
- Unable to access public document HOT 9
- SUGGESTION: Allow specifying a box file_id in box_write HOT 4
- box_ul issue - Error: $ operator is invalid for atomic vectors HOT 17
- Can I get a listing of a shared link? HOT 4
- box_fresh_auth() Error: `cache` must be a valid filename HOT 20
- Delete
- Error when deploying shinyapp with boxr HOT 1
- No prompt to enter token after box_auth() HOT 2
- Read file using Box file path HOT 4
- Question: How to use boxr that uses SAML/Okta authentication HOT 10
- Better token location
- [Question]: Is it possible to use boxr to upload to S3 HOT 1
- What redirect URI to use? HOT 4
- boxr redirect_uri_mismatch Error HOT 1
- redirect_uri_mismatch error even after setting redirect_uri to `http://localhost:1410/`
- Adding tags
- Move jose from suggests to imports HOT 1
- Boxr issue in R studio
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from boxr.