Comments (2)
I encourage readers to migrate going forward.
No better way to encourage people than by deprecating your package :) They'll still be able to use it. npm
just lets them know at install time that they should be using something else. But they are free to ignore the warning and use it anyway.
If you don't want to deprecate, would you at least please put a link in the README to this issue as a "known issue" so that people know there are risks involved with using this package?
from use-react-router.
Hi @mjackson. Thanks for your great work!
While I encourage people to use the first-party hooks, I don't want to deprecate this for users who are unable or unwilling to upgrade to 5.1 or refactor their existing code. A helpful balance may be to set the peerDependency
to ~5.0.0
instead of ^5.0.0
and have this repo's documentation encourage users to read the react-router
's hooks documentation as a preferred alternative.
I'll leave this issue open until I think of the optimal solution for users, and I encourage readers to migrate going forward.
from use-react-router.
Related Issues (19)
- Add Travis key
- [QoL] Warn on missing react-router context HOT 6
- Provide a more informative error message for [email protected] or earlier. HOT 4
- Cannot find SourceMap 'use-force-update.js.map' HOT 1
- Failed to compile HOT 2
- Any example in the docs? HOT 4
- Subscribing to location changes might be a no-op. HOT 4
- why do we need a force update? HOT 1
- Types section is missing in package.json
- Typing errors with updated @types/[email protected] HOT 2
- Incorrect error is thrown when react-router Provider is missing. HOT 11
- Pin peerDependency of react-router HOT 1
- does not read updated parameteres HOT 1
- Thank you! HOT 1
- Allow to use within MemoryRouter HOT 2
- useReactRouter may only be called within a <Router /> context HOT 5
- impossible to get params using typescript HOT 2
- Perhaps add to the docs official implementation? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from use-react-router.