Code Monkey home page Code Monkey logo

Comments (7)

juanparadox avatar juanparadox commented on August 22, 2024 2

@danielmhair Same boat as you, only error present.

from parchment.

danielmhair avatar danielmhair commented on August 22, 2024 1

I'm getting this also when I installed ngx-quill, which installs quill and @types/quill. It only happens when my tsconfig.json file has strict: true. Setting it to strict: false fixes this. However, I need strict: true on my project. So I made a pull request. But to explain in detail, my error is:

node_modules/@types/quill/node_modules/quill/parchment/src/collection/linked-list.ts(9,5)

For this PR, I had to change all undefined to null. All tests are passing. Please let me know if this is not what you are expecting with the linked list. I understand that setting it to null instead of undefined could cause unintended issues, but since its passing tests, I'm assuming the unit tests are covering our bases?

Here is the pull request: #43

from parchment.

danielmhair avatar danielmhair commented on August 22, 2024 1

Hey @jhchen, after you merged master, I tried updating my version of parchment, but it seems to not receive the updates. The version that it installs is 1.1.3. I saw that master has the same version number. Have the changes not been published to npm yet?

from parchment.

juanparadox avatar juanparadox commented on August 22, 2024 1

@danielmhair seeing the same issue as you.

from parchment.

juanparadox avatar juanparadox commented on August 22, 2024

@danielmhair I was going through the same thing and was about to submit a PR as well, seems it is important to allow developers using strict: true to use the types free of error. Beat me to it!

from parchment.

danielmhair avatar danielmhair commented on August 22, 2024

Sounds great @juanparadox! To fix it, I set strict: true initially, and there are a ton more errors that come up from, but since this was the only error that comes up on my end, I felt no need to do more of it. I have tested these changes in my project and it does seem to fix the build errors.

from parchment.

jhchen avatar jhchen commented on August 22, 2024

No it's not pushed. There's some more diligence I need to do before publishing so I'll try to get to that this weekend. FYI for any project that uses version numbers you can look in the commit log and check if the change you are looking for is before or after the version bump.

from parchment.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.