quilir / async-docker Goto Github PK

Current Connect trait implementation for Unix socket connection in this project does not work properly.

Default HTTP/1.1 keep-alive option causes not ending connection at all when one want to chain requests (eg. second request depends on the result of the first one).

Hyper collects first request result, passes it to the next chained future, but next request is never sent. When future with that request is polled, it always returns NotReady - as it was still waiting for the end of the previous query.

I've tested connection via loopback connection with Socat and it works fine (Socat was responding with docker-API-like response).

There should be a status code field in Item in every returned Future.

Currently, Result<Type> is returned and all wrong requests fail at body decoding - it is not as useful as it should be.

I think instead Result<Response<Type>> should be returned, where Response would be something like:

enum Response<Type> {
    Ok { code: u16, struct: Type }
    Wrong { code: u16, struct: Value }
}

A value generated from a wrong response's body often contains useful message field with failure reason.

Currently, the builder uses hardcoded slices as keys in hashmaps.

There should be structs with Option fields for every parameter. It will prevent typo fails in the future - compiler will perform fields and types checks.
Also, lack of required fields should cause some required field is not set Error

Currently, SSL TCP connection does not even compile. It probably does not need a lot of work to fix this, but I do not have time for that right now - it has low priority for me.