Comments (3)
I like your solution 1.
from quickwit.
Looking at this, I am thinking two ways here:
- having
extract_time_range
return ranges likei64::MIN..t
ort..i64::MAX
and handle this internally inMetastore::list_splits()
- extract_time_range return a tuple of
(t, None)
or(None, t)
and changeMetastore::list_splits()
interface to
list_splits(
&self,
index_id: &str,
split_state: SplitState,
start_time: Option<i64>,
end_time: Option<i64>,
)
@fulmicoton If I understand your comment we are leaning towards the second option?
from quickwit.
Another option is extract_time_range to return a tuple of (Bound<i64>, Bound<i64>)
list_splits(
&self,
index_id: &str,
split_state: SplitState,
time_range: (Bound<i64>, Bound<i64>)
)
I tried this but felt like adding complexities since Bound & RangeBounds don't provide much ergonomic/methods with ranges.
from quickwit.
Related Issues (20)
- Add retry if file read stream is broken
- Internal GRPC error without any error log on the server side
- Quickwit thinks its on ECS with pod identiy enabled in EKS HOT 3
- Aggregations that return field values do not respect output format HOT 8
- After replication, CircuitBreaker on WAL could be a problem
- Large batch could be a problem
- Es compatible API missing from our openapi
- Test and Increase ramp up of ingest through quickwit cli
- Smarter retry on ingest v2
- Add trino support by adding missing elasticsearch APIs HOT 3
- Garbage collect checkpoints in the SQS file source
- Make ingest V2 the default ingest HOT 1
- flaky test spotted locally: test_delete_shard_on_eof HOT 1
- [refactoring] Find a solution to avoid deserializing the query_ast over and over HOT 2
- AWS s3 stalled stream upload errors HOT 1
- Make assigning shards logs less verbose
- Quickwit Should Ignore Field queries with a mismatch type HOT 5
- search nodes unresponsive with expensive aggregation HOT 1
- support wildcard in non-suffix position
- support wildcard query from es ast
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from quickwit.