Comments (5)
UPDATE: found 2 bug conditions that will break the babel transformation, guaranteed. Mind you, these all compile and function properly with the regular babel plugin for styled-components. Hope these help with bug fixing! An error that states which file the CSS came from would be super helpful. Let me know if I can help with these, may try to write a pull request later.
Any sort of comment inline in the style definition where the next line starts with a nested template expression. Adding a ;
after the comment works but produces stylelint errors. Ex:
const StyledComponent1 = styled.div`
/* comment */
${props => 'color: blue'};
`
Any nested template literals that don't have a trailing ;
, regardless of if they always return a semicolon. Ex:
const StyledComponent2 = styled.div`
${props => 'color: blue;'}
`
from babel-plugin-styled-components-css-namespace.
The two reproducible cases @zachhardesty7 mentioned above should be fixed in this PR: #39
Once approved, I'll get a new release candidate out for further testing in the wild.
from babel-plugin-styled-components-css-namespace.
Thanks for the heads up and the possible files to repro!
from babel-plugin-styled-components-css-namespace.
Is there any update on this? Seems like a pretty big deal considering the whole thing about styled components is the ability to use javascript inline
from babel-plugin-styled-components-css-namespace.
@supadupdip - Not yet. However, the only inline js that should be affected currently are cases like those demonstrated in #33 (comment)
E.g., the following should work as expected:
const StyledComponent2 = styled.div`
color: ${props => isSuccess ? 'green' : 'red'};
The following fixtures are currently passing for this plugin which show using inline js: https://github.com/QuickBase/babel-plugin-styled-components-css-namespace/blob/master/src/tests/fixtures/complex_styled_component.js
The next block of time I have available to work on this plugin is 5/24 where I hope to close out many of the open issues. However, PRs are always welcome.
from babel-plugin-styled-components-css-namespace.
Related Issues (20)
- Media Query String Interpolation Bug HOT 9
- Unable to make it work at all HOT 2
- Throw an error if defined after babel-plugin-styled-components HOT 3
- Valid CSS cannot be parsed HOT 5
- Issue in Component Interpolation inside `&.className` HOT 1
- Issue with nested pseudo-selectors in expressions HOT 1
- NodeJs compatibility HOT 2
- The development server NOT Starting HOT 2
- Example of a working setup with CRA and Customize-CRA?
- Support for style objects HOT 2
- Plugin gives errors in case of // comments HOT 3
- babel config problem HOT 2
- Conditional style is overwritten in loop when using cssNamespace HOT 5
- Plugin doesn't work with typescript HOT 2
- Works with Emotion? HOT 1
- Does not work at all
- Usage with in an NPM package
- Upgrading styled-components from 5.1.1 to 5.3.5 has broken the plugin HOT 2
- Template literal not accepted HOT 2
- Plugin Not Working with Different Styled Component Syntax HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from babel-plugin-styled-components-css-namespace.