modals aren't auto destroyed on a component unmount about mui-modal-provider HOT 3 CLOSED

@Quernest I'd like to thank you. I've not checked how it works now but you have added this feature so fast. Thanks a lot!
And I'd like to say that I like and enjoy your code.

I'm not sure if it is good to ask it here but I hope you do not mind:

1. Using latest 4 version of material-ui with latest version of typescript I have modal window types like this:

import { ReactNode } from 'react';
import { DialogProps } from '@material-ui/core/Dialog';

export interface IProps extends DialogProps {}

and I get typescript errors:

and I have to update types like this:

import { ReactNode } from 'react';
import { DialogProps } from '@material-ui/core/Dialog';

export interface IProps extends DialogProps {
  onClose: () => void;
  onExited: () => void;
}

Is it your package typings issue or not?

2. now I can pass any props to showModal method.
   Is it possible to update typings to be able to pass only that props which passed modal component supports?

For example if I use showModal like this:

showModal(Modal, modalPropsObject);

I'd like to be able to pass only that props which Modal component declared in its typings for typescript?

P.S. I see you are from Ukraine. Maybe it is possible somehow to contact you? I'm from Belarus and if you do not mind it would be great to discuss these questions if you have time. Thanks a lot.

from mui-modal-provider.

@Quernest I'd like to thank you. I've not checked how it works now but you have added this feature so fast. Thanks a lot!
And I'd like to say that I like and enjoy your code.

I'm not sure if it is good to ask it here but I hope you do not mind:

1. Using latest 4 version of material-ui with latest version of typescript I have modal window types like this:

import { ReactNode } from 'react';
import { DialogProps } from '@material-ui/core/Dialog';

export interface IProps extends DialogProps {}

and I get typescript errors:

and I have to update types like this:

import { ReactNode } from 'react';
import { DialogProps } from '@material-ui/core/Dialog';

export interface IProps extends DialogProps {
  onClose: () => void;
  onExited: () => void;
}

Is it your package typings issue or not?

1. now I can pass any props to `showModal` method.
   Is it possible to update typings to be able to pass only that props which passed modal component supports?

For example if I use showModal like this:

showModal(Modal, modalPropsObject);

I'd like to be able to pass only that props which Modal component declared in its typings for typescript?

P.S. I see you are from Ukraine. Maybe it is possible somehow to contact you? I'm from Belarus and if you do not mind it would be great to discuss these questions if you have time. Thanks a lot.

Thank you for your comment. I am glad that this package is useful to you 🙂

You have this error because the DialogProps don't have the same types as the IProps fields in the library. Especially onClose and onExited fields conflicts with it.

interface IProps {
  // ...
  onClose?: () => void;
  onExited?: () => void;
  // ...
}

To fix this issue, I will remove this fields from the IProps interface and you can extend the DialogProps.

But remember that the open prop is required for the DialogProps interface and optional for IProps. If you are going to use the DialogProps interface this prop will have to be passed in the initial props in showModal or updateModal / modal.update to avoid errors / warnings from typescript. But in any case this property will be set automatically when showModal is called.

Regarding the strict typing of props for a component - I think it might be possible to use Generics. I will create a ticket for a future update.

from mui-modal-provider.

@Quernest thanks a lot!

from mui-modal-provider.