Logging only works with markdown sourced from gatsby-source-filesystem, not contentful about gatsby-remark-oembed HOT 8 CLOSED

Thank you for that insight.

This should be easily fixed as I was only trying to make a more informative logging experience. In this casePath: undefinded. So it is not crucial to make the plugin work, I'll let you know when this is fixed.

from gatsby-remark-oembed.

I managed to create a contentful space to test it out and it works fine.

from gatsby-remark-oembed.

Thank you for letting us know, do you have a public repo I could look at?

from gatsby-remark-oembed.

Nudge @patroza?

from gatsby-remark-oembed.

hi @raae sorry for late reply; don't have the project public right now, but what I found so far is that it probably doesnt support the markdown content to live on contentful instead of on disk?
ie I use "gatsby-source-contentful" not -filesystem

from gatsby-remark-oembed.

So it looks like contentful based remarked fields have no File type field, while gatsby-source-filesystem expects it to exist when you call createFilePath.

if in gatsby-source-filesystem I replace the return fileNode statement with:
return fileNode.internal.type !== 'File' ? undefined : fileNode

the app works, and the oembed works. but oembed logs:
info gatsby-remark-oembed: Successfull embeds: 1 | Path: undefined.

from gatsby-remark-oembed.

I am now using the markdown node's id, instead of trying to get the path.

It would be great if you (@patroza) could test the solution by using npm install raae/gatsby-remark-oembed#logging-bug-#73. This will install the branch with the fix.

from gatsby-remark-oembed.

Great to hear @raae, sorry for late response, missed notification somehow

from gatsby-remark-oembed.