run bamboo in supervisord to recover from fails about bamboo HOT 13 CLOSED

I found one of the example:
https://github.com/CenturyLinkLabs/ctlc-docker-haproxy

I have two requests here:

• possibly moving docker related configs into build directory, this keeps the project root clean
• create a PR instead of issues, this helps me to check out your commit for quick test run and review

Thanks!

from bamboo.

Sure can do.

I can add another endpoint to run haproxy, but after that there would be two instances of haproxy running in that container, isn't it?

from bamboo.

Did you mean builder directory by build dir?

from bamboo.

Would it help if stop the existing haproxy (service haproxy stop) after installation and managing it via supervisord?

from bamboo.

yup, my bad. it's the builder directory.

from bamboo.

That could work, how can I do it?

search for running instance of haproxy and kill it, after start new instance.

Wouldn't then bamboo rerun haproxy once it restarts after failure?

Cool would be having switch to disable starting of haproxy from bamboo. What do you think?

from bamboo.

I think it's misunderstanding - bamboo only manages existing haproxy processes. In other words, it expects HAProxy is already running.

from bamboo.

reload command looks at the HAProxy PID:

https://github.com/QubitProducts/bamboo/blob/master/config/production.example.json#L18

from bamboo.

but if I run docker container, haproxy is running.

I feel dumb, but where do you trigger haproxy?

from bamboo.

This is my assumption - correct me if i'm wrong.

• the Dockerfile installs Haproxy, and it comes with a upstart
• in Dockerfile, you can specifically stop the running haproxy process by running command service haproxy stop after installation
• now, we ask supervisor managing HAProxy & bamboo process for us by specifiying multiple [program:x] doc here

Maybe I'm not aware of other side effect issues?

from bamboo.

I don't think this is the way docker works. it should trigger only binary that is specified in CMD directive or on cli docker run.

But obviously it runs so there's someting I miss...

I will look into it tomorrow.
Thanks for support btw.

from bamboo.

@activars did you see update in #50 ??

from bamboo.

Closed because @veverjak PR has been merged.

from bamboo.