Code Monkey home page Code Monkey logo

Comments (20)

yalinli2 avatar yalinli2 commented on September 25, 2024

Are power_delivery_orc and pipe_heat_loss used anywhere?

self.power_delivery_orc = self.oil_flowrate * ((273.15 + self.oil_temp_out) - (273.15 + self.oil_temp_in)) * self.oil_density * self.oil_specific_heat * (60/1000) # MJ/hr

Similarly, heat_output_water and heat_loss_water_pipe?

self.heat_output_water = self.water_flowrate * ((273.15 + self.water_out_temp) - (273.15 + self.water_in_temp)) * self.water_density_kg_m_3 * self.water_heat_capacity_k_j_kg_k * (60/1000) # MJ/hr

from qsdsan.

yalinli2 avatar yalinli2 commented on September 25, 2024

How come there's 4/200 of an HX and 2.834/2.7 of a pump?

design['OilHeatExchanger'] = OHX_quant = (4/200)

design['Pump'] = Pump_quant = (2.834/2.27)

Similarly for Pump here:

design['Pump'] = Pump_quant = (17.2/2.72)

If adjusting cost based on flow rate, the cost decorator should be used

from qsdsan.

yalinli2 avatar yalinli2 commented on September 25, 2024

The _run method of HydronicHeatExchanger does not include simulation of streams (and OilHeatExchanger does not set the phase of hot_gas_in), if effluents and influents are the same (or have the same mass flow), then something like hot_gas_out.copy_like(hot_gas_in) should be included

from qsdsan.

yalinli2 avatar yalinli2 commented on September 25, 2024

For DryerFromHHX (as well as OilHeatExchanger and HydronicHeaExchanger)

from qsdsan.

lsrowles avatar lsrowles commented on September 25, 2024

Based on the description, the OilHeatExchanger should something to burn to generate the heat, the stream is currently not included in the unit.

The OHX leverages heat produced in the carbonizer base. It does not generate the heat.

from qsdsan.

lsrowles avatar lsrowles commented on September 25, 2024

Are power_delivery_orc and pipe_heat_loss used anywhere?

self.power_delivery_orc = self.oil_flowrate * ((273.15 + self.oil_temp_out) - (273.15 + self.oil_temp_in)) * self.oil_density * self.oil_specific_heat * (60/1000) # MJ/hr

Similarly, heat_output_water and heat_loss_water_pipe?

self.heat_output_water = self.water_flowrate * ((273.15 + self.water_out_temp) - (273.15 + self.water_in_temp)) * self.water_density_kg_m_3 * self.water_heat_capacity_k_j_kg_k * (60/1000) # MJ/hr

You are correct that these values are not used. These calculations are intended to be used for future research on the heat balance of the system and are not used in the current analysis.

from qsdsan.

lsrowles avatar lsrowles commented on September 25, 2024

The _run method of HydronicHeatExchanger does not include simulation of streams (and OilHeatExchanger does not set the phase of hot_gas_in), if effluents and influents are the same (or have the same mass flow), then something like hot_gas_out.copy_like(hot_gas_in) should be included

You are correct. Added on my end. Thanks!

from qsdsan.

lsrowles avatar lsrowles commented on September 25, 2024

How come there's 4/200 of an HX and 2.834/2.7 of a pump?

design['OilHeatExchanger'] = OHX_quant = (4/200)

design['Pump'] = Pump_quant = (2.834/2.27)

Similarly for Pump here:

design['Pump'] = Pump_quant = (17.2/2.72)

If adjusting cost based on flow rate, the cost decorator should be used

These assumptions were made to scale the size equipment based on availability of data for the LCA. Should a comment be added to example these assumptions?

from qsdsan.

lsrowles avatar lsrowles commented on September 25, 2024

Calculations pertaining to the heat balance were added to be leveraged for future research.

breakpoint() for moisture content was added as a check when code was under development and can be removed.

CO2/CH4 to C and NH4 to N were updated on my end. Thanks!

Carbon balance was done based on COD to be consistent between units. C calculations that are commented out can be removed here.

For DryerFromHHX (as well as OilHeatExchanger and HydronicHeaExchanger)

Calculations pertaining to the heat balance were added to be leveraged for future research.

breakpoint() for moisture content was added as a check when code was under development and can be removed.

CO2/CH4 to C and NH4 to N were updated on my end. Thanks!

Carbon balance was done based on COD to be consistent between units. C calculations that are commented out can be removed here.

from qsdsan.

yalinli2 avatar yalinli2 commented on September 25, 2024

A note has been added in the documentation of this class to reflect this

The OHX leverages heat produced in the carbonizer base. It does not generate the heat.

from qsdsan.

yalinli2 avatar yalinli2 commented on September 25, 2024

Left notes at these places (they are currently commented out to avoid unnecessary calculations)

You are correct that these values are not used. These calculations are intended to be used for future research on the heat balance of the system and are not used in the current analysis.

from qsdsan.

yalinli2 avatar yalinli2 commented on September 25, 2024

Also updated in the units used in the gates branch

You are correct. Added on my end. Thanks!

from qsdsan.

yalinli2 avatar yalinli2 commented on September 25, 2024

I've left notes on the documentation of these classes on this, on the gates branch

These assumptions were made to scale the size equipment based on availability of data for the LCA. Should a comment be added to example these assumptions?

from qsdsan.

yalinli2 avatar yalinli2 commented on September 25, 2024

I added a Warnings section in the documentation of these classes to note people that energy balance is not performed (since this is typically expected for a heat exchanger).

For HHXdryer, I also let it issue a warning (during simulation) when the calculated heat_needed_to_dry_35 exceeds heat_supplied (and turns out it exceeds a lot of times), @lsrowles just want to make sure you are aware of this

Calculations pertaining to the heat balance were added to be leveraged for future research.

from qsdsan.

yalinli2 avatar yalinli2 commented on September 25, 2024

I've removed this in the gates branch

breakpoint() for moisture content was added as a check when code was under development and can be removed.

from qsdsan.

yalinli2 avatar yalinli2 commented on September 25, 2024

I changed the following line

waste_out._COD = (waste_in.COD * (waste_in.F_vol/waste_out.F_vol)) - ((drying_CO2_to_air + drying_CH4_to_air) / self.carbon_COD_ratio)

to (note the inclusion of methane)
waste_out._COD = (waste_in.COD*waste_in.F_vol - (drying_CO2_to_air/44*12+drying_CH4_to_air/16*12) / self.carbon_COD_ratio)

And

waste_out.imass['N'] -= drying_NH3_to_air

to
waste_out.imass['N'] -= drying_NH3_to_air / 17 * 14

With notes that 44/12/16/17/14 are molecular weights of CO2/C/CH4/NH3/N

@lsrowles let me know if this doesn't look correct to you, especially concerning the methane thing

CO2/CH4 to C and NH4 to N were updated on my end. Thanks!

from qsdsan.

yalinli2 avatar yalinli2 commented on September 25, 2024

Sounds great, I think this also explains the question you had when we were discussing about this issue, I've removed these legacy comments in the gates branch

Carbon balance was done based on COD to be consistent between units. C calculations that are commented out can be removed here.

from qsdsan.

lsrowles avatar lsrowles commented on September 25, 2024

I added a Warnings section in the documentation of these classes to note people that energy balance is not performed (since this is typically expected for a heat exchanger).

For HHXdryer, I also let it issue a warning (during simulation) when the calculated heat_needed_to_dry_35 exceeds heat_supplied (and turns out it exceeds a lot of times), @lsrowles just want to make sure you are aware of this

Calculations pertaining to the heat balance were added to be leveraged for future research.

The calculations for heat_supplied are not accurate because the area_surface here is just an assumed valued. It is a hypothetical surface area. I added these calculations for future research on the system to leverage. Would you fix the reference in _dryer_from_hhx.tsv for area_surface to be assumed, please? Thanks!

from qsdsan.

yalinli2 avatar yalinli2 commented on September 25, 2024

OK I've fixed it in de0ac1a!

Would you fix the reference in _dryer_from_hhx.tsv for area_surface to be assumed, please?

from qsdsan.

yalinli2 avatar yalinli2 commented on September 25, 2024

There's a minor bug in the fixes below and it's been fixed in 39e4479, all problems in this issue have been fixed

I changed the following line

waste_out._COD = (waste_in.COD * (waste_in.F_vol/waste_out.F_vol)) - ((drying_CO2_to_air + drying_CH4_to_air) / self.carbon_COD_ratio)

to (note the inclusion of methane) waste_out._COD = (waste_in.COD*waste_in.F_vol - (drying_CO2_to_air/44*12+drying_CH4_to_air/16*12) / self.carbon_COD_ratio)

And

waste_out.imass['N'] -= drying_NH3_to_air

to waste_out.imass['N'] -= drying_NH3_to_air / 17 * 14

With notes that 44/12/16/17/14 are molecular weights of CO2/C/CH4/NH3/N

@lsrowles let me know if this doesn't look correct to you, especially concerning the methane thing

CO2/CH4 to C and NH4 to N were updated on my end. Thanks!

from qsdsan.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.