Code Monkey home page Code Monkey logo

Comments (6)

qqxx6661 avatar qqxx6661 commented on July 30, 2024 1

image

看了下,我是用的java.util.ArrayList#ArrayList(java.util.Collection<? extends E>)构造方法,所以是塞了Map的value数组构造进去的。
你可以用这个单测case试下cn.monitor4all.logRecord.test.OperationLogNormalTest#testMethodThrowException

from log-record.

qqxx6661 avatar qqxx6661 commented on July 30, 2024

具体说说?没看出来。

from log-record.

fish-liu avatar fish-liu commented on July 30, 2024

@DaTa
public class LogDTO {

private boolean success;

private String exception;

}

public class Test001 {

public static void main(String[] args) {

    List<LogDTO> logDTOList = new ArrayList<>(3);
    System.out.println("------000-------" + logDTOList.size());
    logDTOList.forEach(logDTO -> {                                      //  此处的是否有问题??
        logDTO.setSuccess(false);
        logDTO.setException("throwable.getMessage()");
        System.out.println("-------------");
    });
    System.out.println("------1111-------" + logDTOList.size());
    for(LogDTO logDTO : logDTOList){
        System.out.println("-------------"+logDTO.getException());
    }
}

}

我的运行结果:
------000-------0
------1111-------0

Process finished with exit code 0

说明 logDTOList.forEach() 根本不会执行
是不是可以说finally 里面的 logDTOList.forEach() 也不会执行,也就是说原方法异常时,不会保存任何操作记录

from log-record.

qqxx6661 avatar qqxx6661 commented on July 30, 2024

你注解@OperationLog一行具体是怎么写的?

我看你上方的代码, new ArrayList<>(3); 然后也没塞值给数组,前后都是0没问题吧。

from log-record.

fish-liu avatar fish-liu commented on July 30, 2024

这个跟@OperationLog 注解没关系吧,

AOP中,原方法异常,进到catch模块,

// 写入异常执行后日志
logDTOList = new ArrayList<>(logDtoMap.values());
logDTOList.forEach(logDTO -> {
logDTO.setSuccess(false);
logDTO.setException(throwable.getMessage());
});

这段代码跟我写的demo 功能一样吧,没有往logDTOList里塞任何数据,就forEach了

最后在执行finally 模块时,不启用线程,会执行 logDTOList.forEach(createLogFunction);
也就等于啥都没执行呗

所以原方法异常时,是不会记录失败日志的对吧

from log-record.

fish-liu avatar fish-liu commented on July 30, 2024

第一眼 看成是 logDTOList = new ArrayList<>(logDtoMap.size()); 了,后面再看这段代码,惯性一直以为是logDtoMap.size()
哈哈哈😆

from log-record.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.