Bug in comparison function since last change about tortellini HOT 9 CLOSED

Alright, hopefully that solves that :)

from tortellini.

You should just use std::equal.

from tortellini.

Fantastic catch, that would have caused some headache later.

Thank you very much.

from tortellini.

e62d812#diff-f018793c8a8f1398780f8e4e1e82e39fR120

You should keep r.end(), because otherwise std::equal will go past the end of r if it's smaller than l. In your code it will never happen because it require that l contain a \0 in the middle of the string (std::string support this) but better safe than sorry.

(@Qix- not sure if you will receive a notification for this comment because the issue is already closed so i tag you, and thanks for the rewards on reddit)

from tortellini.

It wouldn't compile for me when I tried - I'll try again.

And no problem, I appreciate the review very much. :)

from tortellini.

That overload of std::equal isn't available until c++17 c++14 it appears.

Will do some more research.

from tortellini.

You can just check that l.size() == r.size() before calling std::equal if you don't use C++14.

from tortellini.

Man I really must be tired, that is a much better solution.

from tortellini.

By the way, usually you still get notifications on github even after an issue is closed. Once you participate in an issue/PR you have to manually opt-out with the notifications button on the right; the issue status doesn't affect your notifications :)

Thanks again!

from tortellini.