Code Monkey home page Code Monkey logo

Comments (4)

daka1510 avatar daka1510 commented on August 19, 2024

#110 will enable code coverage reports for both, unit and integration tests. Let's continue to use #22 as a follow-up to make it fancier and easier to spot trends over time (e.g. by adding coveralls integration, ...). In a first step we need to manually download a workflow artifact to review coverage metrics. This is not ideal but probably a first step towards betters insights.

What remains to be done to meet the acceptance criteria here

  • review the unit and integration test coverage reports (see #110 (comment) for details)
  • decide if the current coverage is "sufficient"
  • if necessary: identify improvement areas as needed and prioritize follow-up tasks

from qiskit-ibm-runtime.

daka1510 avatar daka1510 commented on August 19, 2024

Let's pick up work here again as soon as the referenced PR (#110) is integrated and the push tests do no longer consistently fail (tracked via #93).

from qiskit-ibm-runtime.

daka1510 avatar daka1510 commented on August 19, 2024

Gathered test coverage information from one of the rare successful integration test runs to unblock working on this issue:
Unit test coverage report - python3.9-ubuntu-latest.zip
Integration test coverage report - legacy-production.zip
Integration test coverage report - cloud-production.zip

Downloaded from a CI run of #114

from qiskit-ibm-runtime.

daka1510 avatar daka1510 commented on August 19, 2024

Data

Coverage Report - Unit Tests
image

Coverage Report - Integration tests run against IBM Quantum
image

Coverage Report - Integration tests run against IBM Cloud
image

Assessment

  • Overall test coverage
    • 57% for unit tests: 57%
    • 62% for integration tests against IBM Cloud
    • 66% for integration tests against IBM Quantum
  • The public API entrpoints in (ibm_runtime_service) are well-covered (80-89%)
  • Modules with little to now test coverage have not yet been enabled yet (visualization / jupyter), should improve via #111 and #112

Though we can always improve, I personally think we're good for a first release and these reports along with the planned enhancements will make sure we keep an eye on coverage metrics anyway.

@jyu00, @rathishcholarajan anything else you see as an open to do here? Otherwise, can we close it?

from qiskit-ibm-runtime.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.