Comments (3)
bouh :p
from ecosystem.
I think we need to address number of issue in current configuration setup:
- rename file appropriately.
qe_config.json
is not the best option - we have this snippet in 3 runner files (coverage, tests, lint) which is not good. We should hide it inside configuration class or refactor somehow https://github.com/qiskit-community/ecosystem/blob/ac1c4a05ec1150f33593ce64dfeffca89465aa3a/ecosystem/runners/python_coverages_runner.py#L41-L50
- Optional: move from json to yaml (as all configs usually in yaml)
- Maybe store configuration class inside
Repository
class and store in db too. So this configuration will be deafult: if repository has config file -> we use it, if not -> we use config stored in DB
from ecosystem.
- rename file appropriately.
qe_config.json
is not the best option
Ok, for a more clear name (config_file, project_file, project_config, testing_config, ... ?)
- we have this snippet in 3 runner files (coverage, tests, lint) which is not good. We should hide it inside configuration class or refactor somehow
Yes, we could make a simple function in the runner class and call it
- Optional: move from json to yaml (as all configs usually in yaml)
hmm, does it really mater ? I don't know the usual best practice, but I find the json file pretty clear to read and easy to fill
- Maybe store configuration class inside
Repository
class and store in db too. So this configuration will be deafult: if repository has config file -> we use it, if not -> we use config stored in DB
Hmm.. for me if the project don't have the config file, we just should use the default parameters and that's it. I don't see the place of these parameters in the db.
And, if a project has a config file I thing he'll keep it and not removing it even if it's not used anymore.
Suggestion
Maybe we can add a check of if already exist a tox file, if yes we don't render our and just run the tests with the one who is already here
from ecosystem.
Related Issues (20)
- [Submission]: QoptKIT library to simulate and compile quantum optical circuits in QISKIT.
- Use rem instead of px in the ecosystem website
- [Submission]: qMuVi - An open-source quantum Music Video tool HOT 3
- [Submission]: SQuADDS v0.20 HOT 1
- [Submission]: Qiskit Metal Docker
- Single source of truth for repository model HOT 2
- Better separation of data and python logic
- Use tempfile for testing
- [Submission]: Test submission
- [Submission]: dynacir, a transpiler plugin for dynamic circuits HOT 1
- [Submission]: qiskit-sat-synthesis HOT 1
- [Submission]: ffsim HOT 1
- [Submission]: POVM Toolbox HOT 1
- Bump requirements
- [Submission]: Scaleway provider for Qiskit HOT 1
- [Submission]: qiskit-nature-cp2k HOT 1
- [Submission]: caml_qiskit HOT 1
- [Project update]: Quantum Serverless to Qiskit Serverless
- [Submission]: Quantum-MasterChef HOT 1
- [Submission]: Exploring Dynamic Circuits through Gibbs Free Energy Calculations and Error Mitigation HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ecosystem.