Code Monkey home page Code Monkey logo

Comments (2)

yaelbh avatar yaelbh commented on July 19, 2024

@nkanazawa1989 Doing this for T1 is not straightforward. For example:

  • The function _initial_guess doesn't have an access to user_p0. This is required for parameter c, whose initial guess is a function of a (either user_p0["a"] or the default initial guess). This can be overcome by ignoring c inside _initial_guess and dealing with it only in _setup_fitting, but a nicer solution is preferable.
  • We need to access the metadata to get the conversion factor. I think this is handled by one of the open PRs.

I'll postpone this task to after the release.

from qiskit-experiments.

nkanazawa1989 avatar nkanazawa1989 commented on July 19, 2024

The _initial_guess function is a helper for RB experiment and it's necessary defined for others (this is defined because IRB also use the same code). I think the implementation of spectroscopy analysis would help the migration.

Regarding the circuit metadata, it is now available by #99. Alternative approach would be adding "unit" to analysis option and use self._get_option("unit") in analysis. I prefer latter one, because unit doesn't change per circuit.

from qiskit-experiments.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.