Code Monkey home page Code Monkey logo

Comments (4)

yaelbh avatar yaelbh commented on July 19, 2024

Is there a way to enforce policy that forbids access to private members? Maybe using lint?

from qiskit-experiments.

nkanazawa1989 avatar nkanazawa1989 commented on July 19, 2024

Regarding linter, I think there are pros and cons of allowing private access. Basically I agree with you, we should remove unreasonable access to private members. However, making all of them public means we will have obligation to maintain the interface for end users -- if we need some spec change, we should add deprecation warning and cannot change the implementation for few months (owing to Qiskit mentenance policy). So sometime it's better to tolerate some private member access.

from qiskit-experiments.

yaelbh avatar yaelbh commented on July 19, 2024

It's a good argument, I didn't think of it. So the issue becomes just removing access to private members that already have getters and setters. Without making others public, and without activating the linter for this purpose.

from qiskit-experiments.

gadial avatar gadial commented on July 19, 2024

Closing as this is currently fixed except for members without getters and setters

from qiskit-experiments.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.