Tool does not work right in LongitudinalPETCT about pettumorsegmentation HOT 7 CLOSED

It may make the most sense to rework this entirely as a Segmentation Editor effect.

from pettumorsegmentation.

It may make the most sense to rework this entirely as a Segmentation Editor effect.

The good news: We have already reworked the tool entirely as a Segment Editor effect and it can already be use e.g. in the Quantiative Reporting module.

The bad news: This doesn't fix the issue when using the "classic" Editor Effect in the LongitudinalPETCT module.

Since the effect tool is passed in the Editor's instance of the UndoRedo class it should be possible to implement the save and restore state functionality without accessing the widget.

The Editor Lib's UndoRedo class has a stateChangedCallback which is used by the EditBox. But the class doesn't allow me registering additional callbacks. So I don't see any good way to monitor when an undo or redo occurs. If you have suggestions, please me know.

from pettumorsegmentation.

We could rework the undo/redo mechanism of the EditorLib code, but is it still needed? Are we ready to switch completely to the SegmentEditor?

from pettumorsegmentation.

I think most people from now on will use the SegmentEditor based Effect and the new Segmentation framework in general, instead of the older Labelmap based Editor. I just don't want to remove the old EditorLib EditorEffect yet, since it's also in use in our PET IndiC module (with working undo/redo), but we're transitioning to using QuantitativeReporting.

Ideally, the Longitudinal Analysis would switch to using the new SegmentEditor framework. But that would require considerably more work than reworking the EditorLib's undo/redo mechanism to allow registering additional callbacks.

from pettumorsegmentation.

@chribaue what is missing in SegmentEditor that is preventing you from implementing "working undo/redo"?

from pettumorsegmentation.

@fedorov As mentioned above, the SegmentEditorEffect has working undo/redo and the EditorEffect has undo/redo that works properly when used in the Editor-Module and in the PET-IndiC module.
But, the EditorEffect's undo/redo does not work properly when used in the LongitudinalPETCT module. The reason is because the Editor's undo/redo functionality in Slicer was not designed in a way that allows developers to extend the undo/redo functionality. Fixing this issue would require changes to Slicer's EditorLib, which is going to be replaced by the newer SegmentEditor.

from pettumorsegmentation.

issue fixed in 82b33b5

from pettumorsegmentation.