Code Monkey home page Code Monkey logo

Comments (15)

andreasneumann avatar andreasneumann commented on September 25, 2024

sample will be provided by Urs together with "Steuerfile"-idea

from qgep.

urskaufmann avatar urskaufmann commented on September 25, 2024

My Order: First the E, then the A. Within the E,A: First the bigger…

I define the scale, style, size, colour of the labels as I define the other labels in the labeldefinition.
I define which reaches are (E,A) are labeled in a txt-file (see example).

Place of the label: is 5mm from the Deckel (5mm x scale) away next to or on the reach. Problem: if the reach ends more than 5mm before the Deckel (special construction), I find no place for the label. Better solution: 5mm from the end of the reach.

In the example with manhole 1333: the label-place needs normaly no manual work, but you can not use the same colors as the reach.
in the example with manhole V52: you have to move two labels manually.

Dont know, how to add the example-file and konfig-file here. I send it to Andreas mailadress

from qgep.

andreasneumann avatar andreasneumann commented on September 25, 2024

Here are two sample images from Urs:
https://github.com/qgep/QGEP/blob/master/gepview/schachtbeschriftung_einlauf_auslauf.png
and
https://github.com/qgep/QGEP/blob/master/gepview/schachtbeschriftung_einlauf_auslauf_2.png

from qgep.

m-kuhn avatar m-kuhn commented on September 25, 2024

At the moment the labels are saved on wastewater structure level but joined to and represented on covers.

Would it make sense to only save the wastewater structure and I/O information on the wastewater structure table and attach the cover information on cover level (i.e. so we have only one appropriate C entry per cover)?

C1 = 493.5
C2 = 490.2
4320.6432
I1 = 401.2
O1 = 400.3
O2 = 400.2

vs.

C = 493.5
4320.6432
I1 = 401.2
O1 = 400.3
O2 = 400.2

and

C = 490.2
4320.6432
I1 = 401.2
O1 = 400.3
O2 = 400.2

from qgep.

andreasneumann avatar andreasneumann commented on September 25, 2024

I think for special structures that have more than one cover we only want one label. These labels are quite big already, so we don't want two or more labels per special structure.

Actually, for special structures we don't want a label on the cover, but outside of the geometry of the special structure. I discsussed this with Nyall - and for the long run there could be an automated label placement for this. Until this works properly, I suggest to have manual label positions for special structures.

Two ore more covers on manholes are very rare. I don't think we have one in Uster.

from qgep.

m-kuhn avatar m-kuhn commented on September 25, 2024

Sounds good to me.

I don't think we want to have a switch on manhole vs. special structure.
We probably want to have a switch on if a custom position is defined (on wastewater structure level).

Proposal (taking into account the assumptions outlined in the above comment):

  • Placed labels on every cover by default
    • including every other cover of the same wastewater structure
  • Unless there is a manual position specified for the wastewater structure
  • Covers should not be numbered

from qgep.

andreasneumann avatar andreasneumann commented on September 25, 2024

But a distinction between manhole and special_structure would make sense - because there are different labeling options for polygons versus points. It wouldn't make sense to label covers of a special_structure, as the label would usually overlap with the polygon geometry and would look ugly. The labels of special structure need to be placed outside of the polygon of the detail geometry of the special structure - not next to the cover.

from qgep.

m-kuhn avatar m-kuhn commented on September 25, 2024

Then we will want

  • two different label fields, one on od_manhole and one on od_special_structure (not sure about the other wastewater structures).
  • or have a switch in vw_qgep_cover on wastewater_structure.detail_geometry IS NULL

from qgep.

sjib avatar sjib commented on September 25, 2024

C1 = 493.5
C2 = 490.2
4320.6432
I1 = 401.2
O1 = 400.3
O2 = 400.2
is now implemented.
The model extension Stammkarte allows to define a main cover. (P2)
open issues: language dependencies

from qgep.

m-kuhn avatar m-kuhn commented on September 25, 2024

Depends on #156

from qgep.

sjib avatar sjib commented on September 25, 2024

Take into consideration main cover?

from qgep.

urskaufmann avatar urskaufmann commented on September 25, 2024

The problem with labelling the wastewater structures:
Users should be able to configure the label-text (without programming).
The sequence
cover / identifier / in / out
is not for everyone the sequence, he is used. In my opinion, it should be
identifier/ cover / in / out or
identifier / Manhole-dimension/cover / in / out or
Identifier / shortcut for function / cover / in / out.
The Shortcut-letters are in German D / E / A (not C / I / O).
Normally, I just want the I/O-levels of the PAA-channels to be written.

I think, there should be a UI to define this things: the sequence of the different lines, the shortcut-letters and which channels I/O level are mentioned.

The next thing is to solve the unnecessary multi-labelling of wastewater structures with more than one cover ore wastewater node (look #356 )

And then is the labelling of the channels with I1, I2 etc if there is more than one I or O. And in principle the same, if there are more than one covers.

from qgep.

urskaufmann avatar urskaufmann commented on September 25, 2024

This is the issue we where talking about this afternoon at codesprint 4: Labeling the I1, I2 along the reach next to the manhole.
The challenge: the reach or reachpoint does not know, which number in the manhole-label it is (I1, I2 or...). Possible solution: create a new field (qgep)_field, where the text I1, I2 or O1 is fixed. The manhole-label takes all information from this field and the level-field and the label along the reach next to the manhole corresponds always with the manhole-label

Sample:
LabelingE1E2

from qgep.

sjib avatar sjib commented on September 25, 2024

@urskaufmann Is this still an issue?

from qgep.

urskaufmann avatar urskaufmann commented on September 25, 2024

Yes, it is. The thing in the first post is not implemented: "Individual reaches should be labeled (E1, E2, E3, etc.) - should be labeled along the reach close to the manhole."
For me it's no more a top priority (it's necessary if you have a printed map, if you work at the screen you can get the info, which level belongs to which reach - and everybody works more and more at the screen...)

from qgep.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.