It is not possible to detect if nested contexts are transactional. about nds HOT 5 CLOSED

This would only be necessary when you want to support transactions, correct? If that's the case, I can definitely get behind this.

from nds.

@derekperkins the issue only has the potential to arise when you are in a transaction. However the solution I propose (https://github.com/qedus/nds/tree/context) would affect the signatures of the whole API. Instead of doing nds.Get(c, key, value) you would need to do c.Get(key, value). I am guessing you would not be happy with this?

There might be a happy middle ground though where only code that runs in a transaction must change...

from nds.

Everything Google is doing is migrating towards using https://godoc.org/golang.org/x/net/context, including the appengine package. My vote would be for you to not introduce your own context, but instead use this new one and pass it through as the first parameter of the function. That's at least the most future proof way that I can think of.

I don't have a great solution for the existing appengine package though, since it doesn't have a Value function you can hook into.

from nds.

That is an excellent suggestion. I am going to refactor the context branch with your suggestions.

from nds.

Fixed in commit 2d34590.

from nds.