Slice bounds out of range when using ./ about goreporter HOT 6 CLOSED

Thank you very much for pointing it out.

from goreporter.

Unfortunately, now all my unit tests fail.
When I try to run go test with an absolute path, it says "cannot import absolute path".

from goreporter.

yes,I am fixing the problem.

from goreporter.

Considering a variety of situations where the project is set to the current path (./) or the upper layer(../), I did not expect an elegant way to accommodate this situation, so I would force -p to set the relative path at the end of the project name.

Do you have a better solution?

from goreporter.

The issue is that filepath.Walk calls filepath.Join, which calls filepath.Clean, and that removes the leading "./", because it's not usually needed. However, go test needs the leading "./", because otherwise it interprets the argument as a package name (relative to "$GOPATH/src").

So the solution is to handle unittest.UnitTest appropriately. If DirList is guaranteed to return relative paths, then just prepending "." + filepath.Separator to the path before calling unittest.UnitTest fixes the issue (only tested on Linux, I think "." works on Windows too).

It seems only unittest has this issue, because it executes go test. The other linters stay in go code, and therefore they all handle the path correctly ("somedir" == "./somedir").

Also, what is the purpose of the variable called system (that's a confusing name). Why not just use filepath.Separator?

from goreporter.

I've pushed a quick and dirty fix that works for me on Linux with -p ./ and -p ../.

from goreporter.