Code Monkey home page Code Monkey logo

Comments (6)

romesco avatar romesco commented on July 30, 2024

@omry The PR for this will also give us a chance to think about how to logically structure managing 'two projects' - both torch and torchvision.

from hydra-torch.

romesco avatar romesco commented on July 30, 2024

Another question is whether torchvision should become a dependency. It will need to be at least for tests.

from hydra-torch.

omry avatar omry commented on July 30, 2024

We need to decide if we want to have a different config distribution (pip pacakge) or if we are good with putting all subprojects in the same artifact.

Is torchvesion released with it's own versioning or is it tied to PyTorch's version?

from hydra-torch.

tkornuta-nvidia avatar tkornuta-nvidia commented on July 30, 2024

please note there is more than torchvision, i.e. torchaudio (that we are using in NeMo) and torchtext (that I don't really have experience)...

from hydra-torch.

tkornuta-nvidia avatar tkornuta-nvidia commented on July 30, 2024

We need to decide if we want to have a different config distribution (pip pacakge) or if we are good with putting all subprojects in the same artifact.

Is torchvesion released with it's own versioning or is it tied to PyTorch's version?

Yap, all those projects have their own versioning.

My proposition is to do it as optional package, with optional dependencies

so one can install

  • torch-configs = torch-configs[torch] -> (torch) [default]
  • torch-configs[all] -> torch + torchvision + torchtext + torchnlp
  • or any subset e.g. torch-configs[torch,torchvision]

here's how we did it in NeMo when it comes to requirements:
https://github.com/NVIDIA/NeMo/blob/90775abc3a413baa0a6c8e68beb6160c7ebd108d/setup.py#L90
(still, I think we can make it better when it comes to actual "installation", as far as I know NeMo tries to install all collections disregarding the user choice during installation)

from hydra-torch.

omry avatar omry commented on July 30, 2024

Okay, so if we do go with different pip packages per target library we support we end up with:
For each package:

  1. What Hydra version (or versions?) a package is supporting.
  2. What version (or versions?) of the library the package is supporting.

I added some text to the google doc about versioning, let's discuss there.

from hydra-torch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.