Code Monkey home page Code Monkey logo

Comments (4)

Chillee avatar Chillee commented on June 20, 2024

Tracked this issue down to https://github.com/pytorch/pytorch/blob/master/aten/src/ATen/native/LinearAlgebra.cpp#L2049

from functorch.

zou3519 avatar zou3519 commented on June 20, 2024

For this issue I think we should just rewrite all of the norm operations to not do what they're doing. It should not be standard for a CompositeImplicitAutograd operator to call into an out variant. In particular, frobenius_norm should not call frobenius_norm_out and instead they should have independent implementations. This gives the following benefits:

  • It solves our problem
  • frobenius_norm is faster due to not having to materialize an extra tensor and copying into it
  • frobenius_norm_out is faster due to not having to materialize an extra tensor and copying into it
    There is a downside to maintainability: if someone makes a change to frobenius_norm then the same change need to be applied to frobenius_norm_out. But I'm not too worried about that.

from functorch.

Chillee avatar Chillee commented on June 20, 2024

It seems like this issue has been fixed? from testing on master.

from functorch.

zou3519 avatar zou3519 commented on June 20, 2024

I modified resize in PyTorch to not skip dispatch if it was operating on functorch wrappers as a short term solution a while back

from functorch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.