Expose more information about function line numbers about typed_ast HOT 9 CLOSED

Whatever solution we pick should also be applied to decorated classes.

from typed_ast.

In python/mypy#3871 we seem to be of the opinion that adding class_lineno and def_lineno attributes are the best solution.

from typed_ast.

To be clear, I am adding this to ClassDef, FunctionDef, and AsyncFunctionDef.

from typed_ast.

It appears this was fixed in python/cpython#9731. Perhaps we could backport that change after the update to being based on the 3.7 ast?

from typed_ast.

Taking into account size of the fix, can we backport just the fix now? Supporting 3.7 in typed_ast may take time because of the ASYNC problems, while this fix looks small and well localized.

from typed_ast.

Sure, I'd be happy to make a PR.

from typed_ast.

OK, let's do this then.

from typed_ast.

So... It looks like we took a different path. In Python 3.8's ast this is fixed, but it was not fixed in Python 3.7's ast. Typed_ast is now based on Python 3.7's ast.

Should we do it or not? I worry that just changing the lineno attribute of FunctionDef and ClassDef nodes will break tons of users' code since it changes where # type: ignore comments would have to go. So maybe let sleeping dogs lie?

from typed_ast.

Let's leave typed_ast alone. With Python 3.8 we can support # type: ignore backward compatibility, see python/mypy#3871 (comment) and further comments. For 3.7 and before we'll stick with the status quo.

from typed_ast.