Comments (8)
And thanks for the change! I'm sure not only PR submitters appreciate the faster turn-around but I bet Travis appreciates us using less free resources. 😄
from core-workflow.
This is now done. @brettcannon could you please close this?
Side note: Should we allow "Core developers" team to close issues on this repo?
from core-workflow.
Closed and now the core team has write permissions (just simply forgot to add the team).
from core-workflow.
I don't think the Doc only test works. See this PR here: python/cpython#3072
The travis run: https://travis-ci.org/python/cpython/builds/263366915 (and it's console log)
It triggered a full code rebuild and test even though the only thing that has changed is Doc/library/socket.rst
from core-workflow.
It was working but it seems something has changed such that it didn't succeed in this case.
from core-workflow.
I've done some investigating and this is due to how Travis gets the merged code from Github.
Following the sequence of commands it used to get the repo here, it went:
git clone --depth=50 https://github.com/ammaraskar/cpython.git
git fetch origin +refs/pull/5/merge
git checkout -qf FETCH_HEAD
I replicated these commands locally and ran git log
and the problem became obvious. Github in their special refs/pull/*/merge
branch creates a merge commit which means at that point this git log looks something like:
commit 472056eb60b0601dcded798229bebbddfd307945 (HEAD)
Merge: b072c6d0c6 86cece89d5
Date: Fri Aug 18 05:43:43 2017 +0000
Merge 86cece89d5c6452a92004af0276147187034d41f into b072c6d0c69849690ff03c0ce4f1911139b02ce6
commit b9ff498793611d1c6a9b99df464812931a1e2d69 (master)
Author: Elmar Ritsch <[email protected]>
Date: Fri Aug 18 05:23:51 2017 +0200
Fix broken `Show Source` links on documentation pages (GH-3113)
The `Show Source` was broken because of a change made in sphinx 1.5.1
In Sphinx 1.4.9, the sourcename was "index.txt".
In Sphinx 1.5.1+, it is now "index.rst.txt"
...
EVERY SINGLE COMMIT TO
MASTER ON A TIME AFTER
MY PR COMMIT DATE
...
commit 86cece89d5c6452a92004af0276147187034d41f
Author: Ammar Askar <[email protected]>
Date: Sat Aug 12 15:15:07 2017 -0400
Fix Linux availability version for SO_PEERSEC
And so the git diff
picks up on all the commits in the middle because the PR commit ends up in a really old slot in history.
from core-workflow.
OK, so it's basically it's imperfect but isn't hurting anything. Thanks for the detailed report, @ammaraskar ! I'm going to close this again and we can just live with occasionally building more than necessary.
from core-workflow.
There's a way around it, I opened up a PR to fix it: python/cpython#3129
Whether it's worth the added complexity to the build process, that I don't know.
from core-workflow.
Related Issues (20)
- Remove myself from the "windows-team" team HOT 2
- Requesting triage membership for Numpy HOT 1
- Add OS-ios label, and later OS-android HOT 1
- `blurb merge`: "No 'section' specified. You must provide one!" HOT 1
- Add label: OS-unsupported HOT 5
- Request for Python triage membership: Matt Page HOT 3
- Request triage team membership for Brett Simmers HOT 2
- Request for Python triage membership: AN Long HOT 3
- Request for Python triage membership: Malcolm Smith HOT 3
- Try out Datadog CI Visibility for CPython HOT 13
- Request for Python triage membership: Peter Lazorchak HOT 4
- Request for Proofreader membership
- Add the topic-repl label HOT 1
- Request for Python triage membership: Savannah Ostrowski HOT 2
- Add the "topic-JIT" label HOT 2
- Remove commit bit from inactive core devs HOT 11
- Make finding CPython issues without PR easier HOT 9
- Require keeping an unreviewed PR open for a period of time HOT 5
- Generate notifications if PRs are merged without review HOT 1
- Request for Python triage membership: Bénédikt Tran HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from core-workflow.