socket.send() raised exception. about websockets HOT 13 CLOSED

Update: I just noticed that the application didn't actually crash, everything still works fine, but I still think this should be handled by the websockets module so it doesn't print "socket.send() raised exception"/stack traces if a client has disconnected (or perhaps pass along the exceptions so they can be handled by applications using the module).

from websockets.

handleConnection should probably end with:

try:
    yield from websocket.recv()
finally:
    wsClients[link_id].remove(websocket)

from websockets.

I'm confident that this commit should fix your problem. Let me know if it doesn't work.

from websockets.

Thanks! I've upgraded to version 2.1, and it doesn't print any tracebacks anymore but it still prints:
"socket.send() raised exception.".

from websockets.

Errors should not pass silently -- PEP 20

;-)

from websockets.

I don't disagree with that, but the problem is that the module (asyncio in this case I believe) is logging the error instead of passing along whatever exception that was raised in socket.send(). This way it can't be handled by the consumer of the API/module ("socket.send() raised exception." isn't very descriptive either), so that message is just trashing the logs when in my use case it should just be ignored because it just means that the client has disconnected before/while calling send().

from websockets.

I'll have a second look at this issue.

from websockets.

asyncio logs this message after 5 attemps to write to a closed socket.

If it's just a race condition when your system is dying under load, there isn't much to fix.

But if it's websockets trying to write data to the connection after the socket dies, then I can do something.

from websockets.

It is websockets trying to write to the connection after the remote connection has disconnected (but websockets hasn't context switched enough to fail the yield from recv before the 5 attempts to send). I have only reproduced it under heavy load (running apachebench on the same machine), so feel free to close it if you feel that this isn't a real issue because it only happens under heavy load. It's not very important to me either way, I just thought I'd report it because I didn't expect this behavior.

from websockets.

Would you mind testing pull request #27 and report if it fixes your problem?

I'm sorry, I haven't replicated your setup yet, so there's a bit of trial and error going on.

from websockets.

This pull request is expected to make yield from client.send(json_data) raise an exception when the socket died, which should allow you to deal with the error as you wish in
https://github.com/marksamman/pylinkshortener/blob/master/app/websocket/__init__.py#L48.

from websockets.

I have confirmed that the pull request fixes my issue. Thanks!

from websockets.

Well thanks a lot for reporting it and persisting until I fixed it ;-)

Let me know if there's anything else I can help with.

from websockets.