Working with Threads about fe HOT 10 CLOSED

Hello, James.
I am using driver.pq3 in my multithread application (connection per thread).
I found that lazy initilization of module's varaibles sometimes makes me to organize my source to prevent errors.

   
        global _pg_iri, _pg_driver, _pg_param
    if _pg_iri is None:
        from . import iri as _pg_iri
        from . import driver as _pg_driver
        from . import clientparameters as _pg_param

But I think, I will be relatively easy to make support of thread safety for model "connection per thread"

from fe.

Hmm. Yeah, that was silly of me.

Could you see if this fixes your issue:

    global _pg_iri, _pg_driver, _pg_param
if _pg_iri is None:
    from . import driver as _pg_driver
    from . import clientparameters as _pg_param
    from . import iri as _pg_iri

Having _pg_iri last should make the race condition benign.

from fe.

Thank you I will try if it is necessary
And... when I wrote that "I will be relatively easy to make" I meant "It will be relatively easy to make" :)

from fe.

Yeah, connection per thread should just work.

from fe.

Hello, I would like to ask if it is still true that to establish and close connection inside threads is OK?

from fe.

Should be. However, when closing a Connection, only one thread should be performing the operation.

from fe.

Hm, not very clear to me. I have one main thread that creates and starts child threads in unpredictable time (all at ones, one after another, overlapping in some way). In each child thread I create separate db connection by calling postgresql.open() and perform queries with db.query(), db.prepare(). What do you mean "However, when closing a Connection, only one thread should be performing the operation"?

• I can not rely on Python garbage cleaning when exiting thread code?
• If I have to close db connection with db.close(), closing one connection can in some way interact with connections from other threads? I am afraid there is no way to do it as threads are completely time independent. They can start and end any time.

from fe.

I can not rely on Python garbage cleaning when exiting thread code?

If you rely on garbage collection, I believe a resource warning will be emitted by Python's socket module.
Doing so will only cause the socket to be closed and no termination message will be issued to the server.
I would not advise relying on garbage collection for Connection close.

If I have to close db connection with db.close(), closing one connection can in some way interact with connections from other threads? I am afraid there is no way to do it as threads are completely time independent. They can start and end any time.

No. The driver is not thread aware and there is no communication between connections. You can either db.close() or with db:, but only one thread should be performing the operation on a single Connection. Sharing a single Connection across multiple threads is not safe unless operations are protected by a synchronization primitive.

If each thread has its own Connection, you're safe.

from fe.

Thanks for explanation. Yes I establish and close connection explicitly in thread function (not passing to thread) so I will early find out if I am safe :)

from fe.

Use the issue as documentation.

from fe.