Code Monkey home page Code Monkey logo

Comments (21)

sigmavirus24 avatar sigmavirus24 commented on June 15, 2024 4

@brettcannon done

from uritemplate.

tacaswell avatar tacaswell commented on June 15, 2024 1

@brettcannon Ping me on email if you want me to do anything.

from uritemplate.

sigmavirus24 avatar sigmavirus24 commented on June 15, 2024 1

@brettcannon you should have been given the ability to craft releases.

from uritemplate.

sigmavirus24 avatar sigmavirus24 commented on June 15, 2024 1

Do we actually want to block a release on that list or do we want to do a release now and address that afterwards as a fast follow?

from uritemplate.

brettcannon avatar brettcannon commented on June 15, 2024 1

https://pypi.org/project/uritemplate/3.0.1/ is now a thing!

@sigmavirus24 would you mind merging #49 and then tagging a release on the repo? At that point I think we are done!

from uritemplate.

lskillen avatar lskillen commented on June 15, 2024

@sigmavirus24 Sorry, I know you're busy, but "hear hear" to the above too. :-) We've been using a branch to get a release with accepted PRs, but an official release would be just that bit nicer. Thank you!

from uritemplate.

tacaswell avatar tacaswell commented on June 15, 2024

Is there anything I can do to help with this?

from uritemplate.

brettcannon avatar brettcannon commented on June 15, 2024

I'm also willing to help with @tacaswell to create a new release as the collections.abc issue is becoming a bit more pressing.

from uritemplate.

sigmavirus24 avatar sigmavirus24 commented on June 15, 2024

@brettcannon what's your PyPI username? You're already a hyper member so I can just add you to PyPI so you can release it

from uritemplate.

brettcannon avatar brettcannon commented on June 15, 2024

@sigmavirus24 brettcannon

from uritemplate.

brettcannon avatar brettcannon commented on June 15, 2024

@tacaswell Thanks! I'll let you know if I need anything after @sigmavirus24 gives me a copy of the keys. 😄

from uritemplate.

brettcannon avatar brettcannon commented on June 15, 2024

Things to do for the release:

  • Update LICENSE to say uritemplate instead of uritemplate.py (PR #44)
  • Update tox.ini for Python 3.7 and 3.8 (PR #45)
  • Update .travis.yml for Python 3.7 and 3.8 (PR #45)
  • Update trove classifiers (PR #45)
  • Update HISTORY.rst (PR #46 )
  • Bump version number appropriately based on what has changed (PR #47 )
  • Verify CI is passing
  • Go over everything once more with @tacaswell to make sure nothing has been missed
  • Create a PR updating the publish date in HISTORY.rst (#49 )
  • Push a new release to PyPI
  • Merge the change to HISTORY.rst
  • Ask @sigmavirus24 to tag a new release here on the repo

from uritemplate.

brettcannon avatar brettcannon commented on June 15, 2024

@sigmavirus24 I personally don't need a release that badly, and at least the first three + trove classifiers seem important to fix for the release itself (especially if there won't be a release that often).

from uritemplate.

brettcannon avatar brettcannon commented on June 15, 2024

Just a quick update for folks: coding is done so that uritemplate has support through Python 3.8. Next bit is updating the the history/changelog and then bumping the version number appropriately based on what the history suggests. After that it's administrative release stuff.

from uritemplate.

brettcannon avatar brettcannon commented on June 15, 2024

@tacaswell I think everything is done and the repo is in its final state (sans HISTORY.rst date fix) for release. Did you want to double-check anything before I cut a release?

from uritemplate.

tacaswell avatar tacaswell commented on June 15, 2024

Everything on the checklist looks good to me. The version diversion between uritemplate and uritemplate.py took me a while to understand, but I think that is OK.

It is probably worth mentioning that support for py26, py32, and py33 are going away in this version from 3.0.0 (viahttps://github.com//pull/39), opened #48 for that.

Does #37 deserve a comment? Technically changes the return type of a public function.

Do we also need a new version of uritemplate.py as well?

from uritemplate.

sigmavirus24 avatar sigmavirus24 commented on June 15, 2024

Does #37 deserve a comment? Technically changes the return type of a public function.

I'm not terribly worried about that since it's really still a set and has all the duck-ish behaviours of a set except that it maintains order. We can call out things are still ordered but I don't think it's super important to call that out especially since the two uritemplate projects merged and this was a compatibility fix for folks familiar with uritemplate.

from uritemplate.

brettcannon avatar brettcannon commented on June 15, 2024

@tacaswell thanks for the double-checking! I'm going to assume that since @sigmavirus24 merged your change that you're good to go on a release so I checked that step off. As for uritemplate.py, I don't have push ownership on that nor do I want them, so that's a decision for @sigmavirus24 . 😄

Hopefully I will have time to push a new version this week sometime.

from uritemplate.

sigmavirus24 avatar sigmavirus24 commented on June 15, 2024

I believe one just installs the other these days and we only need to update one.

from uritemplate.

brettcannon avatar brettcannon commented on June 15, 2024

Unless someone says otherwise, here are the files I plan to upload today sans an appropriate update to the history file: https://send.firefox.com/download/5d9ab05dad26528a/#OJSpApgMtrJityHQH8E7AQ (download expires after 100 downloads or 1 day).

from uritemplate.

brettcannon avatar brettcannon commented on June 15, 2024

Then I think you can close this issue, @sigmavirus24 ! Thanks everyone who helped make this happen.

from uritemplate.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.