Impossible to override create param for model fixture about pytest-factoryboy HOT 10 CLOSED

Accidentally closed this issue. I use that in django project:

class UserFactory(factory.django.DjangoModelFactory):
    class Meta:
        model = settings.AUTH_USER_MODEL

    username = factory.Faker('user_name')

    @factory.post_generation
    def post(obj, create, extracted, **kwargs):
        obj.set_password('password')

If I use user fixture then the model object I get has pk but seems to be not in DB unless I explicitly call user.save().

So this does not work:

def test_foo(user, client):
     client.login(username=user.username, password='password')

client is an instance of TestClient from Django.

Unless I do:

def test_foo(user, client):
     user.save()
     client.login(username=user.username, password='password')

Here is output from IPDB:

ipdb> user.pk
1857
ipdb> client.login(username='vrath', password='password')
False
ipdb> user.save()
ipdb> client.login(username='vrath', password='password')
True

from pytest-factoryboy.

Same question here.

from pytest-factoryboy.

Seems possible but it's not implemented yet. See https://github.com/pytest-dev/pytest-factoryboy/blob/master/pytest_factoryboy/fixture.py#L174
How do you imagine this working?

from pytest-factoryboy.

It's interesting that the line you gave should actually call build or create based on strategy: https://github.com/rbarrois/factory_boy/blob/master/factory/base.py#L78

So this should work, but does not ...

from pytest-factoryboy.

@syradium I think what the OP means is that you want to be able to override the default.

from pytest-factoryboy.

@thedrow I am sorry, OP?

According to the line I gave Factory() call should take into account default strategy. I think it would sufficient if this fixture would take into account default strategy as well. But it looks like it does not. I tried to set BUILD_STRATEGY explicitly but still object isn't created.

In fact fixture object has a pk set but object does not exist in DB which is weird. So maybe Django/pytest-django does something unexpected.

from pytest-factoryboy.

@syradium OP = Original Poster. The one who opened the issue.

from pytest-factoryboy.

@thedrow Oh, did not get that. Yeah, it's a separate issue maybe.

from pytest-factoryboy.

I'm not using Django ORM so I didn't realize that save is being called on the postgen hook. I have to think how to invoke it since all post-gens are deferred

from pytest-factoryboy.

@Glueon I've added support of the _after_postgeneration hook. Could you try if it works for you now in the branch of the PR #22?

from pytest-factoryboy.