Code Monkey home page Code Monkey logo

Comments (1)

jpVm5jYYRE1VIKL avatar jpVm5jYYRE1VIKL commented on May 29, 2024 1

Issue related to following. In 2017 almost everywhere used Gigabits networks.
In file pyrad/pyrad/client.py
in method def _SendPacket(self, pkt, port):
written :

            self._socket.sendto(pkt.RequestPacket(), (self.server, port))

            now = time.time()
            waitto = now + self.timeout

            while now < waitto:
                ready = select.select([self._socket], [], [],
                                    (waitto - now))

Quite often execution time to complete time.time() function cost more than 10ms. + need some time to reach ready = select.select. So if server on gigabit link answer faster than 10ms . In that case packet come to system before installing selector. And will be lost. In case if on server configured ignorant duplicate acct packets . radius client will fall into constant resend accounting till timeout expire. Proposed workaround is change little bit order of operations to


            now = time.time()
            waitto = now + self.timeout

            self._socket.sendto(pkt.RequestPacket(), (self.server, port))

            while now < waitto:
                ready = select.select([self._socket], [], [],
                                    (waitto - now))

Proposal patch #58

from pyrad.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.