Code Monkey home page Code Monkey logo

Comments (17)

prabhuramachandran avatar prabhuramachandran commented on June 9, 2024 1

@avalentino -- I suspected as much, that cython will pass and opencl would not. At least I know where the issue is potentially and can work on a fix that works for both. Thanks for your patience.

from compyle.

prabhuramachandran avatar prabhuramachandran commented on June 9, 2024 1

@avalentino -- this is now merged in master. Thanks for your patience!

from compyle.

avalentino avatar avalentino commented on June 9, 2024

Is there any progress on this?
I have just tested the new release 0.7 and the problem seems to be still there.

from compyle.

prabhuramachandran avatar prabhuramachandran commented on June 9, 2024

Sorry about that, is this both on i386 and armhf? I suspect this is just a poor mapping between the types that we have -- we have perhaps assumed that the world is now 64 bit. Is there a simple way for us to test this ourselves? I can try to spend some time on this later this week but cannot test it, would you be willing to help test this if I push to a public branch for instance?

from compyle.

avalentino avatar avalentino commented on June 9, 2024

Thanks @prabhuramachandran for the quick reply.
Sure I can help to test and I can also try to help with the fix if you provide some guidance.
I can test quite easily on i386, Unfortunately testing on armhf is more complex for me, I have to wait for the standard debian CI.

from compyle.

prabhuramachandran avatar prabhuramachandran commented on June 9, 2024

@avalentino -- sorry my response times can be quite terrible sometimes. Thank you for your kind offer! I will try to push a fix to a branch and let you know this week.

from compyle.

prabhuramachandran avatar prabhuramachandran commented on June 9, 2024

@avalentino -- can you please try the fix-32bit branch I have just pushed and see if that fixes the problem? Many thanks! Also there a way to easily test this on travis-ci to prevent issues going forward?

from compyle.

avalentino avatar avalentino commented on June 9, 2024

Hi @prabhuramachandran unfortunately the test still fails on i386:

https://salsa.debian.org/science-team/compyle/-/jobs/1047959

from compyle.

prabhuramachandran avatar prabhuramachandran commented on June 9, 2024

Thanks @avalentino, I have pushed another small change. Would it be possible to test the latest version of the branch? Thanks!

from compyle.

avalentino avatar avalentino commented on June 9, 2024

Dear @prabhuramachandran the test still fails: https://salsa.debian.org/science-team/compyle/-/jobs/1049211
This time I have also enabled verbose test output and do not caprure output streams.
Please note that the problem seems t affect only the cython backend:

compyle/tests/test_array.py::test_align_multiple[cython] FAILED
compyle/tests/test_array.py::test_align_multiple[opencl] 1 warning generated.
2 warnings generated.
PASSED
compyle/tests/test_array.py::test_align_multiple[cuda] SKIPPED

from compyle.

prabhuramachandran avatar prabhuramachandran commented on June 9, 2024

@avalentino -- Thanks for testing. I've made another fix which removes some unnecessary code. Let's hope this works.

from compyle.

avalentino avatar avalentino commented on June 9, 2024

Hi, @prabhuramachandran it seems you are on the right way.
The test still fails unfortunately [1].
The good news is that now the cython backend works, while the pyopencl is broken (in the previous run it was the contrary)

compyle/tests/test_array.py::test_align_multiple[cython] PASSED
compyle/tests/test_array.py::test_align_multiple[opencl] FAILED
compyle/tests/test_array.py::test_align_multiple[cuda] SKIPPED

Is there a way to change the dtype_to_ctype behavior depending on the calling backend?

[1] https://salsa.debian.org/science-team/compyle/-/jobs/1054489

from compyle.

avalentino avatar avalentino commented on June 9, 2024

Hi @prabhuramachandran, just a reminder.
Now that we have found the origin of the issue it would be nice to have this fixed for Debian 11.

from compyle.

prabhuramachandran avatar prabhuramachandran commented on June 9, 2024

@avalentino -- yes sorry, I am chasing down another urgent bug and should get to the issue later this week.

from compyle.

prabhuramachandran avatar prabhuramachandran commented on June 9, 2024

@avalentino -- I have attempted a more robust fix and force pushed to the fix-32bit branch. Please let me know if this works. Thanks!

from compyle.

avalentino avatar avalentino commented on June 9, 2024

@prabhuramachandran I can confirm that the new fix works correctly. thanks a lot.

from compyle.

prabhuramachandran avatar prabhuramachandran commented on June 9, 2024

@avalentino -- thank you very much for testing!

from compyle.

Related Issues (9)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.