Code Monkey home page Code Monkey logo

Comments (4)

mara004 avatar mara004 commented on June 16, 2024

Hi,

First of all, many thanks for your report, and for hosting pdfium-binaries.

Yes, I noticed these differences in the Windows binaries, and already wondered about them when implementing the corresponding passage in update.py. Feel free to tweak the layout so it is in line with the other packages. I would even appreciate this change.

If you are done, it would be nice if you could leave a short comment, and I will adapt the script accordingly (or you may also submit a PR if you like).

Kind regards

from pypdfium2.

mara004 avatar mara004 commented on June 16, 2024

This is the code in question:

pypdfium2/update.py

Lines 186 to 202 in f41831c

if dirname.startswith('windows'):
bin_name = 'pdfium.dll'
if dirname.endswith('x64'):
bin_dir = join(build_dir,'x64','bin')
elif dirname.endswith('x86'):
bin_dir = join(build_dir,'x86','bin')
elif dirname.endswith('arm64'):
bin_dir = join(build_dir,'arm64','bin')
else:
raise ValueError("Binary directory could not be recognised.")
elif dirname.startswith('darwin'):
bin_name = 'pdfium.dylib'
bin_dir = join(build_dir,'lib')

from pypdfium2.

bblanchon avatar bblanchon commented on June 16, 2024

I just pushed the change; next Monday's build will have the new layout.

from pypdfium2.

mara004 avatar mara004 commented on June 16, 2024

Thanks, I plan to create a branch to change the update script and will merge it into main when the next build arrives.

from pypdfium2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.