Expand test coverage about twine HOT 6 CLOSED

Trying to list out what "test everything" would mean:

Codecov says we're at 67.42% code coverage. Out of 574 tracked lines, we hit 387, partially hit 25, and miss 162. upload.py, for instance, has substantial untested code.

I think we don't have any doctests.

We have some tests running via Travis CI.

We could add PEP 484 annotations (#231).

from twine.

100% coverage or bust is my motto :P

from twine.

Hi @bhrutledge , @dstufft

Is this something I can take a stab at?

I started with twine/utils.py and was able to get 99% test coverage with it, from 96% . I will be happy to create a PR for the same, and then increase coverage for more files, with one file per PR.

Before

Name                           Stmts   Miss Branch BrPart  Cover   Missing
twine/utils.py                  98      4     40      2    96%   111->112, 112, 118-126, 172->177
------------------------------------------------------------------------
TOTAL                          829     70    241     35    88%

After

Name                           Stmts   Miss Branch BrPart  Cover   Missing
twine/utils.py                  98      0     40      1    99%   172->177
------------------------------------------------------------------------
TOTAL                           829     66    241     34    89%

from twine.

@deveshks Yes please! This is how I got started contributing to Twine, at last year's PyCon sprints: #458.

from twine.

@deveshks Yes please! This is how I got started contributing to Twine, at last year's PyCon sprints: #458.

Thanks, I have submitted the first PR towards the effort

from twine.

Coverage is now at 93%. That's satisfactory. Nicer would be to get to 100%, so ongoing contribution is welcomed.

from twine.