Edke, thanks I have been meaning to rewrite the framer code for a while now and I have started on that front. Right now I changed to using a state machine that I hope I can make generic and much more performant that the standard code. Here is my initial commit if you would like to test and see if this solves your problem or if you have anything you can comment on (note it is on branch framer-fix):

1a160e8

from pymodbus.

There is a small typo on line 150 of transaction.py

After this fix, handling a server that went away gave an exception when trying to communicate.
(with the old version None is returned, not what I expect)

Here is the patch:

diff --git a/pymodbus/transaction.py b/pymodbus/transaction.py
index 4000f65..b2040c3 100644
--- a/pymodbus/transaction.py
+++ b/pymodbus/transaction.py
@@ -147,7 +147,7 @@ class ModbusTransactionManager(object):
             # the current frame and alert the application code
             # that there was an error.
             elif self.state == FramerState.ErrorInFrame:
-                _logger.debug("entering error state: %d:%s", len(self.framer._buffer, self.framer._header))
+                _logger.debug("entering error state: %d:%s", len(self.framer._buffer), self.framer._header)
                 self.framer.resetFrame()
                 return False

from pymodbus.

Ah, good find. I'll patch this asap.
On Feb 10, 2015 8:33 AM, "roberthdevries" [email protected] wrote:

There is a small typo on line 150 of transaction.py

Here is the patch:
diff --git a/pymodbus/transaction.py b/pymodbus/transaction.py
index 4000f65..b2040c3 100644
--- a/pymodbus/transaction.py
+++ b/pymodbus/transaction.py
@@ -147,7 +147,7 @@ class ModbusTransactionManager(object):

the current frame and alert the application code

that there was an error.

elif self.state == FramerState.ErrorInFrame:

• _logger.debug("entering error state: %d:%s",
  len(self.framer._buffer, self.framer._header))
• _logger.debug("entering error state: %d:%s",
  len(self.framer._buffer), self.framer._header) self.framer.resetFrame()
  return False

—
Reply to this email directly or view it on GitHub
#28 (comment).

from pymodbus.

This should be fixed with pymodbus v1.5.0 and above (sync client)

from pymodbus.