Comments (4)
Edke, thanks I have been meaning to rewrite the framer code for a while now and I have started on that front. Right now I changed to using a state machine that I hope I can make generic and much more performant that the standard code. Here is my initial commit if you would like to test and see if this solves your problem or if you have anything you can comment on (note it is on branch framer-fix):
from pymodbus.
There is a small typo on line 150 of transaction.py
After this fix, handling a server that went away gave an exception when trying to communicate.
(with the old version None is returned, not what I expect)
Here is the patch:
diff --git a/pymodbus/transaction.py b/pymodbus/transaction.py
index 4000f65..b2040c3 100644
--- a/pymodbus/transaction.py
+++ b/pymodbus/transaction.py
@@ -147,7 +147,7 @@ class ModbusTransactionManager(object):
# the current frame and alert the application code
# that there was an error.
elif self.state == FramerState.ErrorInFrame:
- _logger.debug("entering error state: %d:%s", len(self.framer._buffer, self.framer._header))
+ _logger.debug("entering error state: %d:%s", len(self.framer._buffer), self.framer._header)
self.framer.resetFrame()
return False
from pymodbus.
Ah, good find. I'll patch this asap.
On Feb 10, 2015 8:33 AM, "roberthdevries" [email protected] wrote:
There is a small typo on line 150 of transaction.py
Here is the patch:
diff --git a/pymodbus/transaction.py b/pymodbus/transaction.py
index 4000f65..b2040c3 100644
--- a/pymodbus/transaction.py
+++ b/pymodbus/transaction.py
@@ -147,7 +147,7 @@ class ModbusTransactionManager(object):the current frame and alert the application code
that there was an error.
elif self.state == FramerState.ErrorInFrame:
- _logger.debug("entering error state: %d:%s",
len(self.framer._buffer, self.framer._header))- _logger.debug("entering error state: %d:%s",
len(self.framer._buffer), self.framer._header) self.framer.resetFrame()
return False—
Reply to this email directly or view it on GitHub
#28 (comment).
from pymodbus.
This should be fixed with pymodbus v1.5.0 and above (sync client)
from pymodbus.
Related Issues (20)
- FramerType module not available with pymodbus 3.6.8. HOT 4
- TLS implementation seems broken? HOT 9
- Use pyserial RS485 - not serial_from_url HOT 3
- Serial Communication Drops After Few Messages on Ubuntu HOT 2
- How to get tag name with address HOT 2
- 2 ip address for 1 server HOT 2
- Register data missing HOT 1
- Bug when converting pymodbus.DATATYPE.FLOAT32 to float HOT 6
- pymodbus 3.6.8 does not work, while works with modbus-tk and pymodbus 2.5.3 HOT 5
- Example server_async.py: AttributeError: module 'helper' has no attribute 'get_commandline' HOT 3
- ModbusException not trown while under the hood asyncio.TimeoutError("Server not responding") is fired HOT 3
- Not working after upgrade tp 3.6.9 HOT 7
- examples not working HOT 2
- No response received from remote while modpoll is able to get it HOT 14
- Add issue tracker / source code repository to the doc HOT 4
- move transaction handling into framer socket. HOT 1
- Server and client decoders handle exceptions differently HOT 1
- "no response" or "incomplete message" when using sync client HOT 15
- pymodbus loops indefinitely over received frame HOT 8
- Dealing with a device response that has a wrong length field HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pymodbus.