Code Monkey home page Code Monkey logo

Comments (4)

AlexAndorra avatar AlexAndorra commented on May 24, 2024

Hey @MarcoGorelli !
I'm a bit confused: wasn't this setup already done with PR #123 ? I was under the impression that with this PR merged, checks against isort/black/pyugrade would be run by pre-commit-ci?
And in case of failures, contributors would indeed just have to run pre-commit run --files <notebooks> locally (at least until we allow pre-commit-ci to do the changes itself). Am I mistaken?

from pymc-resources.

MarcoGorelli avatar MarcoGorelli commented on May 24, 2024

#123 just added 'isort' and 'pyupgrade' still need to do 'black' so this is just here as a reminder

from pymc-resources.

AlexAndorra avatar AlexAndorra commented on May 24, 2024

Ah ok, thanks for the clarification 👌

from pymc-resources.

MarcoGorelli avatar MarcoGorelli commented on May 24, 2024

closing this is already mostly there (and it's arguably not too important to have strict checks in the resources repo 😄 )

from pymc-resources.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.