Code Monkey home page Code Monkey logo

Comments (8)

OriolAbril avatar OriolAbril commented on June 6, 2024 3

Hi, glad to see the duplicity was kept to a minimum and you both agreed on how to proceed, thanks especially @almostmeenal.

I just want to note that now with GSoC and especially outreachy (where we have an internship precisely on updating the notebooks in this repo) applications open, more and more people will be working on the repo at the same time, it becomes even more important to follow the guidelines in the contributing guide, that in a worst case scenario already contemplates the possibility of conflicts and duplicated work, giving preference to the first person to comment in the respective issue.

That being said, thanks both for all your contributions, you are both doing amazing work with the notebooks you are updating ❤️

from pymc-examples.

ckrapu avatar ckrapu commented on June 6, 2024 1

Ah, yes. I forgot about the other rv generators. Thanks for the pointer!

from pymc-examples.

mjhajharia avatar mjhajharia commented on June 6, 2024

I can take this up, since it seems similar to the previous two notebooks i was/am working on, I'll make a basic draft PR with the changes listed here and whatever else I can notice, after that you can suggest changes. I believe I've been slightly less observant with respect to noticing possible improvements on my own, so I'll work on that.

from pymc-examples.

OriolAbril avatar OriolAbril commented on June 6, 2024

Sounds great, thanks! I expect this one to be much easier than the rugby one, maybe even easier than the sample_stats one (all naming conventions are tricky).

from pymc-examples.

ckrapu avatar ckrapu commented on June 6, 2024

Sorry for the duplicate effort - I started working on this last night and didn't see the discussion.

from pymc-examples.

mjhajharia avatar mjhajharia commented on June 6, 2024

@ckrapu hi! that's alright, I started working on it half an hour back and I made the numpy changes, I didn't do anything else yet, you can take it up, considering the amount of work you've done(just checked the notebook, it looks really good)
just a lil note: I think you missed using rng in for the binomial one and somewhere, just have a look at that maybe.

from pymc-examples.

mjhajharia avatar mjhajharia commented on June 6, 2024

@OriolAbril considering #98 I'll unassign myself I guess

from pymc-examples.

mjhajharia avatar mjhajharia commented on June 6, 2024

will keep a note of that!

from pymc-examples.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.