NodePiece: A potential issue with anchors not being sorted according to distance from target node about pykeen HOT 4 CLOSED

Indeed, that's not consistent with the OG implementation, anchors after argpartition() should be further sorted by distance. iirc, @mberr went for argpartition for efficiency reasons, though adding a sorting on top of the output should be a negligible compute effort

from pykeen.

Hi @martytom ,

indeed it looks like the CSGraphAnchorSearcher computes the k-closest anchor nodes, but does not guarantee any order between them:

I do not remember whether this was an explicit choice, but @migalkin may be able to tell whether this is consistent with the NodePiece reference implementation / paper version 😉

from pykeen.

@migalkin I opened a PR to fix this: #1318 🙂

from pykeen.

@martytom , the issue has been fixed with #1318 ; until our next release, you need to install from source to get access to it, cf. https://github.com/pykeen/pykeen#installation--

from pykeen.