Code Monkey home page Code Monkey logo

Comments (8)

PierreSchnizer avatar PierreSchnizer commented on June 27, 2024

Thanks for the report.
I will look to it.

from pygsl.

jose-matos avatar jose-matos commented on June 27, 2024

Thank you for looking into this.

For what is worth, in case it helps, here is an example of a failed build of 2.3.3 in Fedora 40:
https://koji.fedoraproject.org/koji/taskinfo?taskID=113035004

The failure happens in all architectures, for example for x86_64 you can see the build log:
https://kojipkgs.fedoraproject.org//work/tasks/5062/113035062/build.log

Feel free to ask for further details.

from pygsl.

PierreSchnizer avatar PierreSchnizer commented on June 27, 2024

https://github.com/pygsl/pygsl/tree/dev/feature/ci-python-matrix should include the fix

Would it possible to check it ?

from pygsl.

jose-matos avatar jose-matos commented on June 27, 2024

The compilation proceeds but then it stops ahead:

  In file included from src/transform/transformmodule.c:43:
  src/transform/space.c:63:52: warning: missing braces around initializer [-Wmissing-braces]
     63 | static PyTypeObject PyGSL_transform_space_pytype = {
        |                                                    ^
  In file included from /usr/include/python3.12/Python.h:44,
                   from Include/pygsl/intern.h:9,
                   from Include/pygsl/error_helpers.h:7,
                   from src/transform/transformmodule.c:8:
  /usr/include/python3.12/object.h:142:9: error: initialization of ‘long int’ from ‘void *’ makes integer from pointer without a cast [-Wint-conversion]
    142 |         (type)                   \
        |         ^
  src/transform/space.c:64:9: note: in expansion of macro ‘PyObject_HEAD_INIT’
     64 |         PyObject_HEAD_INIT(NULL)
        |         ^~~~~~~~~~~~~~~~~~
  /usr/include/python3.12/object.h:142:9: note: (near initialization for ‘PyGSL_transform_space_pytype.ob_base.ob_size’)
    142 |         (type)                   \
        |         ^
  src/transform/space.c:64:9: note: in expansion of macro ‘PyObject_HEAD_INIT’
     64 |         PyObject_HEAD_INIT(NULL)
        |         ^~~~~~~~~~~~~~~~~~
  src/transform/space.c:63:52: warning: missing braces around initializer [-Wmissing-braces]
     63 | static PyTypeObject PyGSL_transform_space_pytype = {
        |                                                    ^
  src/transform/space.c:63:52: warning: missing braces around initializer [-Wmissing-braces]
  In file included from src/transform/transformmodule.c:45:
  src/transform/arraycopy.c: In function ‘PyGSL_copy_array_to_array’:
  src/transform/arraycopy.c:162:43: warning: variable ‘c2’ set but not used [-Wunused-but-set-variable]
    162 |         gsl_vector_complex_float_view c1, c2;
        |                                           ^~
  src/transform/arraycopy.c:162:39: warning: variable ‘c1’ set but not used [-Wunused-but-set-variable]
    162 |         gsl_vector_complex_float_view c1, c2;
        |                                       ^~
  In file included from src/transform/transformmodule.c:55:
  src/transform/wavelet.c: At top level:
  src/transform/wavelet.c:42:44: warning: missing braces around initializer [-Wmissing-braces]
     42 | static PyTypeObject PyGSL_wavelet_pytype = {
        |                                            ^
  /usr/include/python3.12/object.h:142:9: error: initialization of ‘long int’ from ‘void *’ makes integer from pointer without a cast [-Wint-conversion]
    142 |         (type)                   \
        |         ^
  src/transform/wavelet.c:43:9: note: in expansion of macro ‘PyObject_HEAD_INIT’
     43 |         PyObject_HEAD_INIT(NULL)
        |         ^~~~~~~~~~~~~~~~~~
  /usr/include/python3.12/object.h:142:9: note: (near initialization for ‘PyGSL_wavelet_pytype.ob_base.ob_size’)
    142 |         (type)                   \
        |         ^
  src/transform/wavelet.c:43:9: note: in expansion of macro ‘PyObject_HEAD_INIT’
     43 |         PyObject_HEAD_INIT(NULL)
        |         ^~~~~~~~~~~~~~~~~~
  src/transform/wavelet.c:42:44: warning: missing braces around initializer [-Wmissing-braces]
     42 | static PyTypeObject PyGSL_wavelet_pytype = {
        |                                            ^
  src/transform/wavelet.c:42:44: warning: missing braces around initializer [-Wmissing-braces]
  src/transform/space.c:42:1: warning: ‘PyGSL_transform_space_getattr’ declared ‘static’ but never defined [-Wunused-function]
     42 | PyGSL_transform_space_getattr(PyGSL_transform_space *self, char *name);
        | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  src/transform/wavelet.c:25:20: warning: ‘PyGSL_wavelet_methods’ defined but not used [-Wunused-variable]
     25 | static PyMethodDef PyGSL_wavelet_methods[] = {
        |                    ^~~~~~~~~~~~~~~~~~~~~
  src/transform/space.c:297:20: warning: ‘PyGSL_transform_space_methods’ defined but not used [-Wunused-variable]
    297 | static PyMethodDef PyGSL_transform_space_methods[] = {
        |                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  src/transform/space.c:290:20: warning: ‘PyGSL_transform_wavetable_methods’ defined but not used [-Wunused-variable]
    290 | static PyMethodDef PyGSL_transform_wavetable_methods[] = {
        |                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  error: command '/usr/bin/gcc' failed with exit code 1

There are two errors that boil down to:

 /usr/include/python3.12/object.h:142:9: error: initialization of ‘long int’ from ‘void *’ makes integer from pointer without a cast [-Wint-conversion]

These are from the default options in compilation.
Thank you for your quick response.

from pygsl.

PierreSchnizer avatar PierreSchnizer commented on June 27, 2024

Could you try again if pygsl compiles / runs on fedora?

I merged all changes into the main tree.

from pygsl.

jose-matos avatar jose-matos commented on June 27, 2024

Oops. I do not remember to see the last message. :-)

The pre-release that was available compiles fine for me in Fedora 40 (still in the development stage).

from pygsl.

jose-matos avatar jose-matos commented on June 27, 2024

With pre-release I mean: https://github.com/pygsl/pygsl/releases/tag/v2.3.4-pre

from pygsl.

PierreSchnizer avatar PierreSchnizer commented on June 27, 2024

from pygsl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.