Code Monkey home page Code Monkey logo

Comments (6)

mrbean-bremen avatar mrbean-bremen commented on June 20, 2024

You already suppress exceptions by setting suppress_invalid_tags=True, and the invalid tags are just ignored.
What you can't suppress currently is the error logging - I guess the issue is about that?

from pydicom.

joon612 avatar joon612 commented on June 20, 2024

You already suppress exceptions by setting suppress_invalid_tags=True, and the invalid tags are just ignored. What you can't suppress currently is the error logging - I guess the issue is about that?

Indeed.

from pydicom.

mrbean-bremen avatar mrbean-bremen commented on June 20, 2024

What I would have expected in this case (e.g. if suppress_invalid_tags=True) would be a warning, not an error.
But I guess you want to have that logging configured away completely, right?

from pydicom.

joon612 avatar joon612 commented on June 20, 2024

What I would have expected in this case (e.g. if suppress_invalid_tags=True) would be a warning, not an error. But I guess you want to have that logging configured away completely, right?

In fact, there are two parts, one is that the error is too concise, I actually do not know the specific reason for the element is not compliant, the other is that I can't control the log, in the past, this kind of is used as a warning, although I can't control them at that time, second, I actually care more about whether it is exported, if it can be exported or processed, it can not be displayed as a warning, if it (element) can not be exported, export the reason.

from pydicom.

mrbean-bremen avatar mrbean-bremen commented on June 20, 2024

I actually care more about whether it is exported, if it can be exported or processed, it can not be displayed as a warning, if it (element) can not be exported, export the reason.

I guess by "export the reason" you mean log it?
Currently, the error means that an exception has happened during processing, so the tag will not be exported. It makes indeed sense to at least log the original exception in this case instead of the generic one.

from pydicom.

joon612 avatar joon612 commented on June 20, 2024

I guess by "export the reason" you mean log it?
Yes and thanks!

from pydicom.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.