Code Monkey home page Code Monkey logo

Comments (3)

mdczaplicki avatar mdczaplicki commented on July 17, 2024

It actually works like you want (and like I don't want), that it returns non-zero when it modifies a file.

docformatter.............................................................Failed
- hook id: docformatter
- files were modified by this hook

I would like it to Pass even if it modifies a file 😛

from docformatter.

weibullguy avatar weibullguy commented on July 17, 2024

@mdczaplicki, I believe it's pre-commit returning the non-zero exit code when a hook changes a file. See here. A new docformatter exit code won't alleviate the pre-commit behavior. In September 2019, pre-commit returned an exit code of 1 if files were changed, so the pre-commit behavior @trim21 wants existed at the time this issue was opened as well.

Is there some use-case for docformatter returning a non-zero exit code when files are modified in place independent of pre-commit?

from docformatter.

trim21 avatar trim21 commented on July 17, 2024

sorry I haven't used Python for a long time, I have forgotten why I open this issue……

It looks like pre-commit and this tools works fine.

from docformatter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.