Code Monkey home page Code Monkey logo

Comments (7)

kapsh avatar kapsh commented on July 17, 2024 1

Makes sense and even easier.
I have another question then: I can replace argparse argument only or additionally change default values for post_description_blank arguments in functions. But 2nd option will require removing blank lines in tests, is it okay?

from docformatter.

myint avatar myint commented on July 17, 2024 1

Thanks for the reminder:

https://pypi.python.org/pypi/docformatter/1.0

from docformatter.

myint avatar myint commented on July 17, 2024

Yeah, I remember that. Thanks for the reminder! I'm willing to accept a pull request to fix this. I guess it would just be a matter of turning --no-blank on by default and adding a --blank for people who want the old behavior.

from docformatter.

kapsh avatar kapsh commented on July 17, 2024

Personally I would prefer --blank as single option which accepts yes/no and defaults to no (there is possible disadvantage: breaking someone's automated tools with no-blank used).

Thereby I suggest the following behavior:

  • --blank yes OR --blank OR no argument = enable additional blank line.
  • --blank no = disable additional blank line.
  • --no-blank = disable additional blank line and emit a deprecation warning.

How it looks for you?

from docformatter.

myint avatar myint commented on July 17, 2024

I do see advantages to the yes/no style for configuration. But all the rest of the options already use the toggle style where the option turns the feature on. So I think I would prefer to just use --blank for uniformity.

I plan to increment the major version to 1.0 to indicate this interface change.

Thanks

from docformatter.

kapsh avatar kapsh commented on July 17, 2024

All done in #20.

from docformatter.

madig avatar madig commented on July 17, 2024

I'd like to see a new release that ships this feature :) are there showstoppers left?

from docformatter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.