Dropdown list from ipynb allows duplicates but ComboBox from Qt only keep unique item names about magicgui HOT 5 CLOSED

i agree!

from magicgui.

actually, that sounds to me like a bug in our Qt backend... Qt itself has no problem with this:

from qtpy.QtWidgets import QComboBox, QApplication

app = QApplication([])
combo = QComboBox()
combo.addItems(['a', 'b', 'c', 'c'])
combo.show()
app.exec_()

specifically, i would expect this to work fine:

from magicgui.widgets import ComboBox

# two different data values for c
box = ComboBox(choices=[("a", 0), ("b", 1), ("c", 2), ("c", 3)])

box.show(run=True)

but it doesn't because the ComboBox._mgui_set_choices implementation only looks at the name. Haven't dug too deeply there yet, but i'm not sure we should impose the restriction if both Qt and ipynb don't

from magicgui.

Yeah neither backend limit such use. Let's lift this restriction. The implementation now is to have unique choice names

from magicgui.

It appears that modifying the current implementation of the Qt ComboBox resulted in 3 failures among the original tests:

=========================== short test summary info ============================
FAILED tests/test_container.py::test_reset_choice_recursion - assert (0, 0, 1... <- original
FAILED tests/test_widgets.py::test_separator[ipynb] - assert (1, 2, 4, 6, 7, ... <- new test
FAILED tests/test_widgets.py::test_separator[qt] - AssertionError: assert 21 ... <- new test
FAILED tests/test_widgets.py::test_unhashable_choice_data - AssertionError: a... <- original
FAILED tests/test_widgets.py::test_categorical_change_choices[ComboBox] - ass... <- original
============= 5 failed, 357 passed, 22 skipped, 1 xfailed in 7.36s =============

I guess these changes would lead to a minor release? Let's consider another PR later this week if necessary. For #638, let's retain the original implementation. What do you think? 🤔

from magicgui.

If we allow multiple items with the same name, how would this impact the ability for users to select options by name?

from magicgui.