Ender integration broken by require('util') about clone HOT 10 CLOSED

bummer :(

from clone.

@ded Sorry, Dustin. Didn't do it on purpose.

from clone.

Thanks for the super quick fix!

from clone.

Sorry, my fault! I'm a new contributor, and didn't understand why util had been shim'd.

from clone.

@nathanmacinnes It wasn't! As a maintainer of the module, it's my duty to ensure that functionality isn't removed by accident.

from clone.

Added a comment to prevent future accidents. :)

from clone.

For the record, I'm not sure I agree with the decision though, having looked into what ender actually is. From their website: "small, loosely coupled modules are the future, and large, tightly bound monolithic libraries are the past". Duplicating functionality which could easily be filled by a separate util shim (such as https://github.com/mattdesl/browserify-shim-util) is much more complient with the ender philosophy as well as recognised good practice.

from clone.

It's mostly so that it can work as a standalone. One can't really declare util as a dependency since it's a node native.

from clone.

Yes, I understand that. But as I said, I don't think it fits with the philosophy of either Ender or node. It would be simple enough to say in the description that it's "compatible with ender, when used with a util shim such as ..."

To put it another way, does every module declaring compatibility with Ender which requires an isArray function have to re-implement util?

from clone.

Generally I would say you're right, but I'll stay with the current implementation for practical reasons.

from clone.