Comments (10)
bummer :(
from clone.
@ded Sorry, Dustin. Didn't do it on purpose.
from clone.
Thanks for the super quick fix!
from clone.
Sorry, my fault! I'm a new contributor, and didn't understand why util had been shim'd.
from clone.
@nathanmacinnes It wasn't! As a maintainer of the module, it's my duty to ensure that functionality isn't removed by accident.
from clone.
Added a comment to prevent future accidents. :)
from clone.
For the record, I'm not sure I agree with the decision though, having looked into what ender actually is. From their website: "small, loosely coupled modules are the future, and large, tightly bound monolithic libraries are the past". Duplicating functionality which could easily be filled by a separate util shim (such as https://github.com/mattdesl/browserify-shim-util) is much more complient with the ender philosophy as well as recognised good practice.
from clone.
It's mostly so that it can work as a standalone. One can't really declare util
as a dependency since it's a node native.
from clone.
Yes, I understand that. But as I said, I don't think it fits with the philosophy of either Ender or node. It would be simple enough to say in the description that it's "compatible with ender, when used with a util
shim such as ..."
To put it another way, does every module declaring compatibility with Ender which requires an isArray
function have to re-implement util?
from clone.
Generally I would say you're right, but I'll stay with the current implementation for practical reasons.
from clone.
Related Issues (20)
- npm README HOT 8
- TypeError: 'set alt' called on an object that does not implement interface HTMLImageElement.
- better check for global.Buffer HOT 1
- 'toString' field removed from cloned object HOT 3
- Clone breaking v8 somehow HOT 7
- var a={};a.b=a;clone(a);这种循环引用将报错 HOT 3
- Cannot clone a URL in Node >= 10 HOT 1
- WeakMap and WeakSet errors HOT 1
- Doesn't clone npm modules HOT 1
- V*:internal Error while cloning an axios object HOT 6
- Cannot clone Vue component HOT 1
- Clone still fails when cloning an object that does not have setters defined on some of its properties HOT 1
- Private properties break clones
- Prova
- Security Vulnerability HOT 3
- Not cloning object getters and setters as expected HOT 2
- Spiegel HOT 1
- latest version of npmjs is not updated HOT 1
- TypeError: Method _external called on incompatible receiver #<SecureContext> HOT 1
- TypeError: Illegal invocation (in Chromium) HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from clone.