Comments (9)
The Benchmarks ran successfully! Thanks @kanderso-nrel
from pvlib-benchmarks.
Sorry for pasting all the screenshots, I couldn't understand the error properly.
from pvlib-benchmarks.
Hi @Naman-Priyadarshi, thanks for filing this issue. Right now we run the benchmarks in two environements: one with python 3.6 and on with 3.8. It looks like creating the 3.6 environment is what's failing on your computer. Our benchmark server runs linux, so I'm not entirely surprised that it doesn't work on windows. One quick fix just to get things working on your computer might be to disable the 3.6 environment by deleting/commenting out these lines in the configuration file: https://github.com/pvlib/pvlib-python/blob/master/benchmarks/asv.conf.json#L115-L125
Of course we should think about better fixes for the longer term. A couple ideas:
- Fiddle with the package versions to find a combination that doesn't fail on Windows
- Stop benchmarking on python 3.6 (it's reached EOL anyway), and replace it with a newer version like 3.9 or 3.10
from pvlib-benchmarks.
I removed the lines to disable the 3.6v environment but there's a new error now
i.e.
from pvlib-benchmarks.
Hmm, I'm not sure about that one. It kind of looks like there's some artifact of an old build left over. Can you locate that file and delete it? Restarting your computer might help too, if it's something silly like an old process didn't close that file properly. Otherwise I'm not sure what to suggest.
from pvlib-benchmarks.
I located the file and deleted it, but I'm still getting the same error. (Restarted my computer too)
from pvlib-benchmarks.
Should I try setting up the benchmark in linux?
from pvlib-benchmarks.
Update: asv check
ran successfully in Linux and gave the following output:
· Discovering benchmarks
·· Creating conda environment for conda-py3.8-ephem-h5py-numba-numpy-pandas-scipy..............................................
·· Uninstalling from conda-py3.8-ephem-h5py-numba-numpy-pandas-scipy
·· Building 5cb695d2 <master> for conda-py3.8-ephem-h5py-numba-numpy-pandas-scipy..
·· Installing 5cb695d2 <master> into conda-py3.8-ephem-h5py-numba-numpy-pandas-scipy.
· Checking benchmarks
·· No problems found.
But after running the next step i.e. asv dev
there's an error
(also I have some suggestions for Readme.md)
from pvlib-benchmarks.
Good progress! Looks like the example benchmarks you're running are written for python 2.x, but you're running on 3.7, so no big surprise that it's failing. I guess maybe you copied the example benchmarks from here? Since the failures are in the benchmark code itself, it seems like ASV itself is working correctly, which is great! FYI I just sent in this PR to update the asv docs to not use those old 2.x examples anymore: airspeed-velocity/asv#1207
Anyway, instead of using those dummy example benchmarks, I guess the next step is to use the real pvlib benchmarks. If you have the pvlib-python
repository next to the pvlib-benchmarks
repository, I think all you need to do is modify the configuration file to point to the real benchmarks location like how the nightly job script does it:
So it should probably look like this:
"repo": "../pvlib-python",
...
"benchmark_dir": "../pvlib-python/benchmarks/benchmarks",
I have some suggestions for Readme.md
A PR with improvements would be most welcome! I originally wrote those instructions for myself in case we needed to switch machines at some point in the future. I didn't really think anybody else would read them, and I've not had any reason to update them until now :)
from pvlib-benchmarks.
Related Issues (3)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pvlib-benchmarks.