Crash if launching CameraActivity multiple times about cameraview-ex HOT 8 CLOSED

@pcm2a I couldn't reproduce this behaviour using your demo branch #118 I also confirmed memory usage after closing and opening (also taking photos in between) camera activity multiple times and it seems normal. Let me know when you have more insights on this or more specific details about reproducing the issue.

from cameraview-ex.

I will try to migrate the changes over in small batches and see if I can figure out when the issue appears. I will also monitor memory to see if that is what is causing the issue.

from cameraview-ex.

I'm going to close this until I can provide any better information. I ran the profiler and memory and cpu both look great.

from cameraview-ex.

I found the missing piece. If the layout has the activity starting in video_capture instead of single_capture mode then I get the crash. If set to single_capture I can open the camera unlimited times. I have updated the example.

Also if I try to launch in single_capture and then change to video_capture once the activity starts, eventually I run into the same issue. Maybe something is not getting closed/cleaned up when leaving the activity in video mode.

I cannot reproduce this with a branch that is before the latest batch of merges.

from cameraview-ex.

Another thing I have noticed. I can launch in single_capture mode, manually change to video_capture mode, exit, repeat, works every time.

from cameraview-ex.

Updated the sample PR with a fix but I'm not sure it's the right thing to do.

from cameraview-ex.

@pcm2a #123 and #124 might have fixed this issue. Can you please confirm?

from cameraview-ex.

I am no longer able to reproduce the issue with the latest changes, thanks!

from cameraview-ex.