Use Ord by default for nub, difference, etc about purescript-arrays HOT 6 CLOSED

nub is such a common source of accidental performance problems in Haskell code, so I'm very much +1 on this. The extra package's implementation of nubOrd doesn't depend on sets or maps.

from purescript-arrays.

This is a little bit difficult with respect to dependencies because we would probably want to depend on sets to do this, but maps (which is a dependency of sets) already depends on arrays. So that's one issue to sort out, if we do agree that we want to do this.

I think this is another reason in favor of purescript-deprecated/purescript-sets#46

from purescript-arrays.

On further thought, it's not clear to me that Set is necessary, or beneficial, to do this. We could use Array's own sort, which uses FFI to the JS engine's native Array.sort, and do nub the imperative way. It would avoid the extra dep, and also quite possibly be faster.

from purescript-arrays.

I've taken a shot at nub here: #128

from purescript-arrays.

Currently nub preserves order, though, ie nub xs == xs when xs has no duplicates. If I understand correctly your implementation doesn’t have this property. I think it’s a useful property, though, and so I’d rather not lose it.

from purescript-arrays.

Resolved in the 0.12 branch

from purescript-arrays.