Code Monkey home page Code Monkey logo

Comments (5)

giuseppeg avatar giuseppeg commented on May 22, 2024

Since

By default, grid units don't have any margin/padding. If you want to add these, put them in a child container.

there is no need for that

from pure.

ericf avatar ericf commented on May 22, 2024

+1 for looking into to this. @msweeney it would be great to get your thoughts on this too.

from pure.

msweeney avatar msweeney commented on May 22, 2024

I'm assuming the rationale for overriding default box-sizing is so that borders and padding can be applied directly to units, but it would be good to call out the actual issue this resolves.

Pros:

  • can add padding + borders to units

Cons:

  • lose legacy IE support (box-sizing is IE8+)
  • added specificity makes it harder to override/unset box-sizing

I'd prefer we didn't have an opinion either way, and just use the default, assuming users can customize as needed.

from pure.

ericf avatar ericf commented on May 22, 2024

I'd prefer we didn't have an opinion either way, and just use the default, assuming users can customize as needed.

Yeah, good idea, that's seems like the smart thing to do. @tilomitra we could handle this through documentation, e.g. on the site's grids page we could so an example that uses box-sizing and one which doesn't, describing the pro/cons that @msweeney listed.

from pure.

tilomitra avatar tilomitra commented on May 22, 2024

@ericf @msweeney I'm okay with this. Closing this out and adding it as a documentation issue on pure-site:
https://github.com/yui/pure-site/issues/85

from pure.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.