Code Monkey home page Code Monkey logo

Comments (5)

daenney avatar daenney commented on June 26, 2024

If you read through the 641245 you'll notice that it's not a bug, it's defined behaviour in Apt.

If you want to add a comment to Apt you simply start a line with Explanation: the rest of the comment.

Therefor you can do something like this:

file { '/etc/apt/preferences':
  ensure => file,
  content => 'Explanation: preferences are being managed by Puppet in preferences.d',
}

If you have a pull request to fix this I'd be more than willing to review it and help out with the tests.

from puppetlabs-apt.

wmarler avatar wmarler commented on June 26, 2024

Wrong. If you had bothered to test you would have seen that this commenting
style does not work. See
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=732746 .

On Fri, Feb 21, 2014 at 11:56 AM, Daniele Sluijters <
[email protected]> wrote:

If you read through the 641245https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=641245you'll notice that it's not a bug, it's defined behaviour in Apt.

If you want to add a comment to Apt you simply start a line with Explanation:
the rest of the comment.


Reply to this email directly or view it on GitHubhttps://github.com//issues/199#issuecomment-35761167
.

from puppetlabs-apt.

daenney avatar daenney commented on June 26, 2024

Wrong.

You pointed us to bug 641245 which has nothing to do with empty files or the Explanation tag not working, it has to do with a faulty comment style which led me to assume you tried the # style of comments.

If you had bothered to test

I did test. However my testing machines are Debian Unstable / Sid and the issue has already been solved there.

I'm just another community member trying to help people get their fixes in. I do this in my free time to try and help others out, no need to be rude.

As I said before, if you have code to fix this I'm more than happy to look it over and see if I can get it merged in.

from puppetlabs-apt.

wmarler avatar wmarler commented on June 26, 2024

I am sorry that I was snarky and said "if you'd bothered to test" -- I do
not use Jesse or Sid (I'm working with production machines), and it didn't
occur to me that you would. I'm glad to hear the fix makes my bug report
seem non-reproducible, and I appreciate you donating your time.

I am sorry to say I don't have a fix to contribute anymore : (.

Please note that in Squeeze and Wheezy (at least as of today) the apt
version is still too old, and having either an empty preferences file, one
with #-style comments, or one with a single "Explanation: ..." style
comment will not work. Using a single "Explanation: ..." style comment will
work, as long as it's followed with "Package: " line. The
"" does not have to be a valid package.

On Fri, Feb 21, 2014 at 4:46 PM, Daniele Sluijters <[email protected]

wrote:

Wrong.

You pointed us to bug 641245 which has nothing to do with empty files, it
has to do with a faulty comment style which led me to assume you tried the

style of comments.

If you had bothered to test

I did test. However my testing machines are Debian Unstable / Sid and the
issue has already been solved there.

I'm just another community member trying to help people get their fixes
in. I do this in my free time to try and help others out, no need to be
rude.

As I said before, if you have code to fix this I'm more than happy to look
it over and see if I can get it merged in.


Reply to this email directly or view it on GitHubhttps://github.com//issues/199#issuecomment-35785724
.

from puppetlabs-apt.

daenney avatar daenney commented on June 26, 2024

@wmarler I just pushed PR #240 . Could you test it and see if it works for you?

from puppetlabs-apt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.